Bug 177244

Summary:

[Win] Cygwin 64-bit EWS process cannot find Visual Studio installation.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

Tools / Tests

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

177316

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2017-09-20 09:38:25 PDT

The 64-bit shell process should try to find Visual Studio in the 32-bit program files folder, not the 64-bit program files folder.

Attachments
Patch (1.47 KB, patch) 2017-09-20 09:41 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (1.70 KB, patch) 2017-09-25 09:03 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (1.71 KB, patch) 2017-09-25 09:25 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2017-09-20 09:41:23 PDT

Created attachment 321324 [details] Patch

Per Arne Vollan

Comment 2 2017-09-20 10:03:09 PDT

Thanks for reviewing!

WebKit Commit Bot

Comment 3 2017-09-20 11:04:47 PDT

Comment on attachment 321324 [details] Patch Clearing flags on attachment: 321324 Committed r222272: <http://trac.webkit.org/changeset/222272>

WebKit Commit Bot

Comment 4 2017-09-20 11:04:48 PDT

All reviewed patches have been landed. Closing bug.

Alex Christensen

Comment 5 2017-09-21 11:35:13 PDT

This broke some EWS bots. See https://webkit-queues.webkit.org/results/4617782 for an example.

Per Arne Vollan

Comment 6 2017-09-21 11:41:15 PDT

(In reply to Alex Christensen from comment #5) > This broke some EWS bots. See > https://webkit-queues.webkit.org/results/4617782 for an example. I'll look into it, thanks!

WebKit Commit Bot

Comment 7 2017-09-21 12:12:04 PDT

Re-opened since this is blocked by bug 177316

Per Arne Vollan

Comment 8 2017-09-25 09:03:07 PDT

Created attachment 321690 [details] Patch

Per Arne Vollan

Comment 9 2017-09-25 09:25:05 PDT

Created attachment 321692 [details] Patch

Per Arne Vollan

Comment 10 2017-09-25 12:29:03 PDT

Comment on attachment 321692 [details] Patch Thanks for reviewing!