Bug 17718 – REGRESSION (r30391): GMail: Safari won't display the Edit Link dialogue

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Justin Garcia]

Log in to a GMail account
Compose a new message
Type a word in the compose area
Select it
Click the "Link" button in the toolbar

The link creation box should appear over the document, and the rest of the document should be grayed out.  Instead the link creation box is appended to the document (scroll down to see it).

The error console reports:

Undefined value
http://mail.google.com/mail/?ui=2&view=js&name=js&ids=1fw6vr42tnziw (line 190)

Line 190 shows:

b){if(B){Ec(a,b)}else{var c=lk?td:ie;a[c]=b}},Xea="break-word",Yea="-moz-pre-wrap",Zea="-o-pre-wrap",$ea="pre-wrap",afa=function $afa$(a){if(B){gd(a[q],xn);a[q].wordWrap=Xea}else if(jk){gd(a[q],Yea)}else if(ik){gd(a[q],Zea)}else{gd(a[q],$ea)}},Bp="rtl",Cp="direction",Dp=function $Dp$(a){return Bp==dp(a,Cp)},Ep="MozUserSelect",Fp="WebkitUserSelect",Gp=function $Gp$(){if(jk){return Ep}else if(lk){return Fp}return null},Hp="unselectable",bfa=function $bfa$(a){if(jk||lk){return a[q][Gp()].toLowerCase()==

<rdar://problem/5779984> REGRESSION (r30377-30398): GMail: Safari won't display the Edit Link dialogue

[Justin Garcia]

Introduced in http://trac.webkit.org/projects/webkit/changeset/30391

[Justin Garcia]

Looks like there was a small typo in binding/js/JSCSSStyleDeclarationCustom.cpp:

     for (unsigned i = 1; i < length; ++i) {
         if (!prefix[i])
             return isASCIIUpper(propertyName.data()[i].unicode());
-        if (propertyName.data()[0].unicode() != prefix[0])
+        if (propertyName.data()[i].unicode() != prefix[i])
             return false;
     }
     return false;

fixes it.  No layout test yet though.

[Darin Adler]

Oh, bad regression. Good catch. Really sorry for introducing this!

[Justin Garcia]

Fixed in http://trac.webkit.org/projects/webkit/changeset/30952