Bug 17707

Summary: Conditionalize use of SAFARI_THEME in WebKitClassFactory
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to avoid linking to SafariTheme.dll if not using safari theme aroben: review+

Brent Fulgham
Reported 2008-03-07 11:49:44 PST
The windows-only WebKitClassFactory.cpp class links to the SAFARI_THEME library. This is a problem if you want to build a Cario-backed version of WebKit since it requires CoreGraphics to work. Someday, the themes will be standardized under a more modular infrastructure, but until then a reasonable work-around is to not link to SAFARI_THEME when the "USE(SAFARI_THEME)" test fails.
Attachments
Patch to avoid linking to SafariTheme.dll if not using safari theme (1.62 KB, patch)
2008-03-07 11:55 PST, Brent Fulgham 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2008-03-07 11:55:37 PST
Created attachment 19592 [details] Patch to avoid linking to SafariTheme.dll if not using safari theme
Adam Roben (:aroben)
Comment 2 2008-03-07 11:57:52 PST
Comment on attachment 19592 [details] Patch to avoid linking to SafariTheme.dll if not using safari theme r=me
Mark Rowe (bdash)
Comment 3 2008-03-07 13:16:27 PST
Landed in r30877.
Note You need to log in before you can comment on or make changes to this bug.