Bug 177038

Summary: Add an option to run-jsc-stress-tests to limit tests variations to a basic set
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfbastien, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2017-09-16 13:43:33 PDT
run-jsc-stress-tests has a --quick option, but that runs a minimal number of tests. It would be good to have something between the minimal --quick set and the full set of test variation.
Attachments
Patch (8.65 KB, patch)
2017-09-16 14:14 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2017-09-16 14:14:24 PDT
Created attachment 321012 [details] Patch
JF Bastien
Comment 2 2017-09-16 14:38:47 PDT
Comment on attachment 321012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321012&action=review r=me > JSTests/ChangeLog:8 > + * stress/unshiftCountSlowCase-correct-postCapacity.js: Disabled this test on ARM64 iOS devices Do you know how much memory is needed? Would be good to know when to enable again.
Michael Saboff
Comment 3 2017-09-17 07:34:24 PDT
(In reply to JF Bastien from comment #2) > Comment on attachment 321012 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321012&action=review > > r=me > > > JSTests/ChangeLog:8 > > + * stress/unshiftCountSlowCase-correct-postCapacity.js: Disabled this test on ARM64 iOS devices > > Do you know how much memory is needed? Would be good to know when to enable > again. It ran out of memory after using 800-850MB. On a MacBook Pro I ran the the same test and saw a high usage of 5.4GB as reported by vmmap --dirty.
WebKit Commit Bot
Comment 4 2017-09-17 08:39:06 PDT
Comment on attachment 321012 [details] Patch Clearing flags on attachment: 321012 Committed r222135: <http://trac.webkit.org/changeset/222135>
WebKit Commit Bot
Comment 5 2017-09-17 08:39:07 PDT
All reviewed patches have been landed. Closing bug.
Saam Barati
Comment 6 2017-09-17 12:45:04 PDT
Comment on attachment 321012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321012&action=review > Tools/Scripts/run-jsc-stress-tests:767 > + return if !$isFTLPlatform Why this change?
Michael Saboff
Comment 7 2017-09-18 12:49:51 PDT
Comment on attachment 321012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321012&action=review >> Tools/Scripts/run-jsc-stress-tests:767 >> + return if !$isFTLPlatform > > Why this change? This is a bug fix I added. The statement was doing the opposite of what was intended as the following tests are FTL tests.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:26:39 PDT
<rdar://problem/34693287>
Note You need to log in before you can comment on or make changes to this bug.