Bug 177029

Summary:

[Mac] Upstream miscellaneous WebKitSystemInterface functions

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, eric.carlson, joepeck, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2017-09-15 17:09:24 PDT

[Mac] Upload miscellaneous WebKitSystemInterface functions

Attachments
Patch (86.73 KB, patch) 2017-09-15 17:22 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (85.07 KB, patch) 2017-09-15 21:28 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (85.12 KB, patch) 2017-09-15 21:44 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (85.16 KB, patch) 2017-09-15 21:58 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (85.44 KB, patch) 2017-09-15 22:07 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (85.00 KB, patch) 2017-09-16 13:45 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (86.73 KB, patch) 2017-09-16 14:13 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (86.97 KB, patch) 2017-09-16 14:33 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (87.07 KB, patch) 2017-09-16 15:08 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (88.17 KB, patch) 2017-09-16 15:36 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (88.50 KB, patch) 2017-09-16 20:29 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-09-15 17:22:31 PDT Comment hidden (obsolete)

Created attachment 320975 [details] Patch

Andy Estes

Comment 2 2017-09-15 21:28:29 PDT Comment hidden (obsolete)

Created attachment 320988 [details] Patch

Build Bot

Comment 3 2017-09-15 21:29:47 PDT Comment hidden (obsolete)

Attachment 320988 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4686: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:65: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:67: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:72: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:74: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 4 2017-09-15 21:44:43 PDT Comment hidden (obsolete)

Created attachment 320991 [details] Patch

Build Bot

Comment 5 2017-09-15 21:47:07 PDT Comment hidden (obsolete)

Attachment 320991 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4686: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 6 2017-09-15 21:58:42 PDT Comment hidden (obsolete)

Created attachment 320993 [details] Patch

Build Bot

Comment 7 2017-09-15 22:00:29 PDT Comment hidden (obsolete)

Attachment 320993 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4686: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 8 2017-09-15 22:07:09 PDT Comment hidden (obsolete)

Created attachment 320994 [details] Patch

Build Bot

Comment 9 2017-09-15 22:09:55 PDT Comment hidden (obsolete)

Attachment 320994 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4686: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 10 2017-09-16 13:45:42 PDT Comment hidden (obsolete)

Created attachment 321009 [details] Patch

Build Bot

Comment 11 2017-09-16 13:48:04 PDT Comment hidden (obsolete)

Attachment 321009 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4686: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 12 2017-09-16 14:13:10 PDT Comment hidden (obsolete)

Created attachment 321011 [details] Patch

Build Bot

Comment 13 2017-09-16 14:15:34 PDT Comment hidden (obsolete)

Attachment 321011 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4687: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 14 2017-09-16 14:33:53 PDT Comment hidden (obsolete)

Created attachment 321013 [details] Patch

Build Bot

Comment 15 2017-09-16 14:36:24 PDT Comment hidden (obsolete)

Attachment 321013 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4687: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 16 2017-09-16 15:08:11 PDT Comment hidden (obsolete)

Created attachment 321015 [details] Patch

Build Bot

Comment 17 2017-09-16 15:10:55 PDT Comment hidden (obsolete)

Attachment 321015 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4687: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 18 2017-09-16 15:36:11 PDT Comment hidden (obsolete)

Created attachment 321016 [details] Patch

Build Bot

Comment 19 2017-09-16 15:38:44 PDT Comment hidden (obsolete)

Attachment 321016 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4687: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 20 2017-09-16 20:29:47 PDT

Created attachment 321022 [details] Patch

Build Bot

Comment 21 2017-09-16 20:32:38 PDT

Attachment 321022 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:4687: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 3 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 22 2017-09-18 09:21:32 PDT

Comment on attachment 321022 [details] Patch Clearing flags on attachment: 321022 Committed r222150: <http://trac.webkit.org/changeset/222150>

WebKit Commit Bot

Comment 23 2017-09-18 09:21:34 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 24 2017-09-27 12:26:03 PDT

<rdar://problem/34693269>

Note You need to log in before you can comment on or make changes to this bug.