Bug 176952 – Layout test inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is flaky.

• Component: New Bugs
• Status: RESOLVED FIXED

[Matt Lewis]

inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is a flaky failure on macOS Sierra WK2 according to the flakiness dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreakpoints%2Fresolved-dump-all-pause-locations.html

There doesn't appear to be a clear regression point on the dashboard however

Results:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r222038%20(4294)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/4294

Diff:
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-actual.txt
@@ -1,5 +1,7 @@
 Checking all resolved breakpoint locations in a script.
 
+ERROR: No domain dispatcher registered for domain 'Memory'
+ERROR: No domain dispatcher registered for domain 'Memory'
 
 == Running test suite: Debugger.resolvedBreakpoint.dumpAllLocations
 -- Running test case: Debugger.resolvedBreakpoint.dumpAllLocations.General

[Joseph Pecoraro]

Yay! We caught an issue! Very easy fix.

[Joseph Pecoraro]

Created attachment 320815 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 320815 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320815&action=review

r=me, with a nit

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:289
> +            console.error("No domain dispatcher registered for domain '" + this._domainName + "', for event '" + this._domainName + "." + eventName + "'");

This would be easier to read as a template string.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/222052/webkit>

[Radar WebKit Bug Importer]

<rdar://problem/34693432>