Summary: | Storage Access API: Make document.hasStorageAccess a function and always allow access for same-origin iframes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||
Component: | WebKit2 | Assignee: | John Wilander <wilander> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, rniwa, webkit-bug-importer, wilander | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 176862 | ||||||||||
Attachments: |
|
Description
John Wilander
2017-09-14 13:05:43 PDT
Re-titling to reflect how this was designed. Created attachment 328541 [details]
Patch
Style errors are all of the 'Extra space before ( in function call' variety in the callback parameters. Attachment 328541 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1404: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1414: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:248: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:271: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:352: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:353: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:5809: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:5820: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/page/ChromeClient.h:470: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/page/ChromeClient.h:471: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:147: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:148: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h:84: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h:85: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1023: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1024: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:1259: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:1264: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 18 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 328541 [details] Patch Attachment 328541 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5509148 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html Created attachment 328545 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Ryan and I looked into the El Cap test crash. It's unrelated. Comment on attachment 328541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328541&action=review r=me, but please correct the minor style issues I mentioned before landing. > Source/WebCore/dom/Document.cpp:7416 > + auto& topSecurityOrigin = this->topDocument().securityOrigin(); You don't need 'this->topDocument()' here, just "topDocument()" should work. > Source/WebCore/dom/Document.cpp:7423 > + if (page) { We prefer: "if (Page* page = this->page()) {" since page is not used outside the conditional. Comment on attachment 328545 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The test failure is not related to this patch.
Created attachment 328596 [details]
Patch for landing
Thanks for the review, Brent! Fixed the two style issues. Comment on attachment 328596 [details] Patch for landing Clearing flags on attachment: 328596 Committed r225583: <https://trac.webkit.org/changeset/225583> All reviewed patches have been landed. Closing bug. |