Summary: | [Curl] Create a class dedicated to handle SSL related task | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, Basuke.Suzuki, buildbot, commit-queue, galpeter, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Basuke Suzuki
2017-09-14 08:54:05 PDT
Created attachment 320772 [details]
patch
Attachment 320772 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320827 [details]
fix
Created attachment 320829 [details]
fix
Comment on attachment 320829 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=320829&action=review > Source/WebCore/platform/network/curl/CurlSSLHandle.cppSource/WebCore/platform/network/curl/SSLHandle.cpp:146 > +// CurlSSLVeritifer ------------------------------------------------- I don't think comments like this are helpful. This one's spelled wrong. > Source/WebCore/platform/network/curl/CurlSSLHandle.h:45 > +class CurlSSLSettings { We should have one class per file. This file contains no class called CURLSSLHandle. Created attachment 320952 [details]
fixed
Fixed. Separate files, use proper name for classes and remove unnecessary comments. Also reduce usage of singleton(), but put them into CurlContext. Comment on attachment 320952 [details] fixed View in context: https://bugs.webkit.org/attachment.cgi?id=320952&action=review > Source/WebCore/platform/network/curl/CurlSSLHandle.cpp:103 > + auto valueIter = (it->value).begin(); > + for (; valueIter != (it->value).end(); ++valueIter, ++certsIter) { it->value should at least be given a name. This loop can be made to be much more clear. > Source/WebCore/platform/network/curl/CurlSSLVerifier.h:91 > + This is a lot of whitespace. Let's not. Created attachment 320967 [details]
fixed
(In reply to Alex Christensen from comment #8) > Comment on attachment 320952 [details] > fixed > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320952&action=review > > > Source/WebCore/platform/network/curl/CurlSSLHandle.cpp:103 > > + auto valueIter = (it->value).begin(); > > + for (; valueIter != (it->value).end(); ++valueIter, ++certsIter) { > > it->value should at least be given a name. This loop can be made to be much > more clear. Replaced with std::equal() > > Source/WebCore/platform/network/curl/CurlSSLVerifier.h:91 > > + > > This is a lot of whitespace. Let's not. removed. Comment on attachment 320967 [details] fixed Clearing flags on attachment: 320967 Committed r222147: <http://trac.webkit.org/changeset/222147> All reviewed patches have been landed. Closing bug. |