Bug 176895

Summary:

Disallow passing a null program to getFragDataLocation.

Product:

WebKit

Reporter:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Component:

WebGL

Assignee:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, buildbot, cdumez, commit-queue, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Ms2ger (he/him; ⌚ UTC+1/+2)

Reported 2017-09-14 03:29:15 PDT

I missed this one before. This matches the specification as well as Gecko and Chromium.

Attachments
Patch (5.54 KB, patch) 2017-09-14 03:40 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Patch (5.49 KB, patch) 2017-09-15 03:36 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 1 2017-09-14 03:40:39 PDT

Created attachment 320755 [details] Patch

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 2 2017-09-14 07:48:38 PDT

Patch depends on the one in bug 176892.

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 3 2017-09-15 03:36:25 PDT

Created attachment 320887 [details] Patch

Build Bot

Comment 4 2017-09-15 03:37:37 PDT

Comment on attachment 320887 [details] Patch Rejecting attachment 320887 [details] from commit-queue. Ms2ger@igalia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Commit Bot

Comment 5 2017-09-15 04:53:45 PDT

Comment on attachment 320887 [details] Patch Clearing flags on attachment: 320887 Committed r222083: <http://trac.webkit.org/changeset/222083>

WebKit Commit Bot

Comment 6 2017-09-15 04:53:47 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2017-09-27 12:30:49 PDT

<rdar://problem/34693407>

Note You need to log in before you can comment on or make changes to this bug.