Bug 176846

Summary:

Use OptionSet<HangingPunctuation> instead of bitmask

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, darin, thisiskatewinslet

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-elcapitan	none

Daniel Bates

Reported 2017-09-13 09:33:55 PDT

Use OptionSet<HangingPunctuation> instead of bitmask.

Attachments
Patch (10.66 KB, patch) 2017-09-13 09:40 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (12.54 KB, patch) 2017-09-13 10:18 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (13.35 KB, patch) 2017-09-13 10:35 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (13.82 KB, patch) 2017-09-13 10:49 PDT, Daniel Bates	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (2.88 MB, application/zip) 2017-09-13 12:48 PDT, Build Bot	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-09-13 09:40:39 PDT

Created attachment 320645 [details] Patch

Daniel Bates

Comment 2 2017-09-13 10:18:55 PDT

Created attachment 320653 [details] Patch

Daniel Bates

Comment 3 2017-09-13 10:35:06 PDT

Created attachment 320656 [details] Patch

Daniel Bates

Comment 4 2017-09-13 10:49:08 PDT

Created attachment 320658 [details] Patch

Alex Christensen

Comment 5 2017-09-13 11:13:40 PDT

Comment on attachment 320658 [details] Patch Could you make HangingPunctuation an enum class at the same time? Is NoHangingPunctuation still needed?

Build Bot

Comment 6 2017-09-13 12:48:56 PDT

Comment on attachment 320658 [details] Patch Attachment 320658 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4536502 New failing tests: fast/text/hanging-punctuation-first-ws.html fast/text/hanging-punctuation-variable-font-size.html fast/text/hanging-punctuation-allow-end-basic.html fast/text/hanging-punctuation-allow-end.html fast/text/hanging-punctuation-last-rtl.html fast/text/hanging-punctuation-first.html fast/text/hanging-punctuation-last-ws.html fast/text/hanging-punctuation-first-and-last-together.html fast/text/hanging-punctuation-last.html fast/text/hanging-punctuation-first-rtl.html fast/text/hanging-punctuation-allow-end-inlines.html fast/css/round-trip-stroke-width-using-computed-style.html

Build Bot

Comment 7 2017-09-13 12:48:58 PDT

Created attachment 320677 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Darin Adler

Comment 8 2017-10-08 14:32:04 PDT

Comment on attachment 320658 [details] Patch Looks like assertions are being hit on Mac debug EWS.

Daniel Bates

Comment 9 2018-08-04 16:48:23 PDT

This was fixed in the patch for bug #186015.

Note You need to log in before you can comment on or make changes to this bug.