Bug 176846

Summary: Use OptionSet<HangingPunctuation> instead of bitmask
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, darin, thisiskatewinslet
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-elcapitan none

Description Daniel Bates 2017-09-13 09:33:55 PDT 
Use OptionSet<HangingPunctuation> instead of bitmask.
Comment 1 Daniel Bates 2017-09-13 09:40:39 PDT 
Created attachment 320645 [details]
Patch
Comment 2 Daniel Bates 2017-09-13 10:18:55 PDT 
Created attachment 320653 [details]
Patch
Comment 3 Daniel Bates 2017-09-13 10:35:06 PDT 
Created attachment 320656 [details]
Patch
Comment 4 Daniel Bates 2017-09-13 10:49:08 PDT 
Created attachment 320658 [details]
Patch
Comment 5 Alex Christensen 2017-09-13 11:13:40 PDT 
Comment on attachment 320658 [details]
Patch

Could you make HangingPunctuation an enum class at the same time?  Is NoHangingPunctuation still needed?
Comment 6 Build Bot 2017-09-13 12:48:56 PDT 
Comment on attachment 320658 [details]
Patch

Attachment 320658 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4536502

New failing tests:
fast/text/hanging-punctuation-first-ws.html
fast/text/hanging-punctuation-variable-font-size.html
fast/text/hanging-punctuation-allow-end-basic.html
fast/text/hanging-punctuation-allow-end.html
fast/text/hanging-punctuation-last-rtl.html
fast/text/hanging-punctuation-first.html
fast/text/hanging-punctuation-last-ws.html
fast/text/hanging-punctuation-first-and-last-together.html
fast/text/hanging-punctuation-last.html
fast/text/hanging-punctuation-first-rtl.html
fast/text/hanging-punctuation-allow-end-inlines.html
fast/css/round-trip-stroke-width-using-computed-style.html
Comment 7 Build Bot 2017-09-13 12:48:58 PDT 
Created attachment 320677 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Darin Adler 2017-10-08 14:32:04 PDT 
Comment on attachment 320658 [details]
Patch

Looks like assertions are being hit on Mac debug EWS.
Comment 9 Daniel Bates 2018-08-04 16:48:23 PDT 
This was fixed in the patch for bug #186015.