Bug 176811

Summary:

Web Inspector: Color created from an RGB/HSL triplet returns bad component arrays

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bensims880, brianmckay070, britishwriteruk, christinejohn999, commit-queue, elisjohnson395, flavia.derby110, georgekhancock784, gereb70650, gistjames850, hartrichard331, inspector-bugzilla-changes, joepeck, jonathnaylor, lilliecourtright, maronetammy, miltonwhite381, nelsonmurdockk, nk8253243, oliyanabeth, pl2340801, rahysalexander90, saraacron0, sarahbeeny, sarawatsons123, scilife873, thisiskatewinslet, thomasmarsden970, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

176822

Attachments:

Description	Flags
Patch	none
Patch	none

Matt Baker

Reported 2017-09-12 15:09:40 PDT

Summary: Color created from an RGB/HSL triplet returns bad component arrays. For example: > color = new WI.Color(WI.Color.Format.RGB, [255, 0, 0]) > color.rgb < [255, 0] > color.rgba < [255, 0, 0] The results from storing the triplet in either `_rgba` or `_hsla`, which are both assumed to have a length of four. The problem also causes unexpected results when converting a Color created from components to a string: > color.toString() < "rgba(255, 0, 0)" > color.toString(WebInspector.Color.Format.ShortHEX) < "rgba(255, 0, 0)" We should be able to convert a Color created from components just as easily as one created using `fromString()`.

Attachments
Patch (8.80 KB, patch) 2017-09-12 15:21 PDT, Matt Baker	no flags	Details Formatted Diff Diff
Patch (10.39 KB, patch) 2017-09-12 15:23 PDT, Matt Baker	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.