Bug 176809

Summary:

Switch text tracks to release logging

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

brianmckay070, buildbot, commit-queue, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none
Proposed patch	none
Proposed patch.	none
Proposed patch.	none

Eric Carlson

Reported 2017-09-12 14:33:27 PDT

Switch existing logging in the various text track classes to release logging.

Attachments
Proposed patch. (100.40 KB, patch) 2017-09-14 15:35 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Proposed patch (75.56 KB, patch) 2017-09-14 17:39 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Proposed patch. (75.00 KB, patch) 2017-09-14 18:44 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Proposed patch. (74.99 KB, patch) 2017-09-14 18:54 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-09-12 15:13:55 PDT

<rdar://problem/34397605>

Eric Carlson

Comment 2 2017-09-14 15:35:55 PDT

Created attachment 320835 [details] Proposed patch.

Build Bot

Comment 3 2017-09-14 15:50:29 PDT

Attachment 320835 [details] did not pass style-queue: ERROR: Source/WebCore/html/track/TrackBase.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:41: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:53: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 17 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 4 2017-09-14 17:39:35 PDT

Created attachment 320854 [details] Proposed patch

Build Bot

Comment 5 2017-09-14 17:41:56 PDT

Attachment 320854 [details] did not pass style-queue: ERROR: Source/WebCore/html/track/TrackBase.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:41: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:53: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 17 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 6 2017-09-14 18:44:42 PDT

Created attachment 320860 [details] Proposed patch.

Build Bot

Comment 7 2017-09-14 18:47:12 PDT

Attachment 320860 [details] did not pass style-queue: ERROR: Source/WebCore/html/track/TrackBase.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:41: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:53: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/track/TrackBase.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/track/TrackBase.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 17 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 8 2017-09-14 18:54:22 PDT

Created attachment 320862 [details] Proposed patch.

WebKit Commit Bot

Comment 9 2017-09-15 09:20:11 PDT

Comment on attachment 320862 [details] Proposed patch. Clearing flags on attachment: 320862 Committed r222091: <http://trac.webkit.org/changeset/222091>

WebKit Commit Bot

Comment 10 2017-09-15 09:20:12 PDT

All reviewed patches have been landed. Closing bug.

MckayBrian

Comment 11 2022-10-27 05:02:06 PDT

If you don't know why an exception failed, logging errors in your code is useless for tracking down bugs. By enabling the display of the whole stack trace, including variable values, Loguru aids in problem identification. http://britishdissertationhelp.blogspot.com/

Note You need to log in before you can comment on or make changes to this bug.