| Summary: | [GStreamer] Many media source tests crashing with GStreamer-CRITICAL **: _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||||
| Component: | Media | Assignee: | Nael Ouedraogo <nael.ouedp> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboya, buildbot, cgarcia, commit-queue, eocanha, mcatanzaro, nael.ouedp, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| See Also: | https://bugzilla.gnome.org/show_bug.cgi?id=782217 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Catanzaro
2017-09-12 13:27:37 PDT
Has this started appearing on the bots just recently? The issue has been there for long when I ran the tests in my computer. No, it's been happening for ages. But I changed criticals to be fatal yesterday to reflect the severity of these bugs, so only now are the tests crashing. By the way, half these tests were already failing anyway. The test expectations are starting to become a bit messy as I've now filed a second bug report for many multimedia tests that previously had only failure bug reports and now have a second crash bug report as well. That started a couple weeks ago, not just yesterday. Really not pleased about the state of our multimedia tests. :( Created attachment 321561 [details]
Patch
It seems a Gstreamer bug. Uploaded patch should fix the issue. wdyt? It's fine by me as long as the patch is submitted upstream. Enrique, can you review it please? Comment on attachment 321561 [details] Patch Attachment 321561 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4630156 New failing tests: fast/canvas/webgl/texImage2D-video-flipY-true.html Created attachment 321586 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
This is being tracked in GStreamer bugzilla here: https://bugzilla.gnome.org/show_bug.cgi?id=782217 The patch looks good to me, but could you please submit the original gst-plugins-good patch to the bug above? The patch has been approved upstream. In the meanwhile until the next stable version is released we should commit the patch internally for our jhbuild so we stop getting stderr in our test runs. You may want to consider this upstream commit from Sebastian when doing so: https://github.com/GStreamer/gst-plugins-good/commit/728a1629cf9fd7f4a728477bda1d13a1ecc219bb Created attachment 323414 [details]
Patch
Thanks for the reviews. Comment on attachment 323414 [details] Patch Clearing flags on attachment: 323414 Committed r223178: <https://trac.webkit.org/changeset/223178> All reviewed patches have been landed. Closing bug. Comment on attachment 323414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323414&action=review > Tools/gstreamer/jhbuild.modules:81 > + <patch file="gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch" strip="1"/> Is this patch already upstream? in which version is (or will be) released? Please, when adding patches to jhbuild, add a comment line before the patch replying this question and documenting what the patch does and why it's needed. Otherwise, when bumping the gst version we don't know if we still need this patch or not. > Is this patch already upstream? in which version is (or will be) released? Yes, it is fixed upstream. GStreamer bug report [1] indicates that the target milestone is version 1.13.1. > Please, when adding patches to jhbuild, add a comment line before the patch > replying this question and documenting what the patch does and why it's > needed. Otherwise, when bumping the gst version we don't know if we still > need this patch or not. I will upload a new patch to document why this gstreamer patch is required. [1] https://bugzilla.gnome.org/show_bug.cgi?id=782217 |