Bug 176800 – [Cleanup] Cleanup uses of the FileList class

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

[Cleanup] Cleanup uses of the FileList class

[Sam Weinig]

Created attachment 320564 [details]
Patch

[Build Bot]

Attachment 320564 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gtk/DragDataGtk.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 320568 [details]
Patch

[Build Bot]

Attachment 320568 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gtk/DragDataGtk.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 320568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320568&action=review

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2700
>                  if (!readFile(file))
>                      return JSValue();
>                  if (m_isDOMGlobalObject)
> -                    files.append(WTFMove(file));
> +                    files.append(file.releaseNonNull());

This would be nicer if you made readFile take no parameters and return a RefPtr.

[WebKit Commit Bot]

Comment on attachment 320568 [details]
Patch

Clearing flags on attachment: 320568

Committed r222025: <http://trac.webkit.org/changeset/222025>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 320568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320568&action=review

> Source/WebCore/html/FileInputType.cpp:156
> +    auto* fileList = element().files();
> +    ASSERT(fileList);

I would write:

    ASSERT(element().files());
    auto& fileList = *element().files();

> Source/WebCore/html/FormController.h:48
> +        m_values.append(value);

Can this be done more efficiently? Seems like this will allocate a larger Vector than is needed.

[Sam Weinig]

(In reply to Darin Adler from comment #8)
> Comment on attachment 320568 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320568&action=review
> 
> > Source/WebCore/html/FileInputType.cpp:156
> > +    auto* fileList = element().files();
> > +    ASSERT(fileList);
> 
> I would write:
> 
>     ASSERT(element().files());
>     auto& fileList = *element().files();
> 
> > Source/WebCore/html/FormController.h:48
> > +        m_values.append(value);
> 
> Can this be done more efficiently? Seems like this will allocate a larger
> Vector than is needed.

Thanks. I'll address these with https://bugs.webkit.org/show_bug.cgi?id=177004.

[Radar WebKit Bug Importer]

<rdar://problem/34693325>