run-webkit-tests should have a watchdog timer (and timeout long tests)

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

run-webkit-tests should have a watchdog timer (and timeout long tests)

I've occasionally hit problems where I've made tests time-out.  It seems run-webkit-tests should just have a watchdog and automagically timeout tests which take to long.  Similar to the existing "wait until done" watchdog.  We could start with a very high value and lower it over time.

[Stephanie Lewis]

Something similar to the following could work

     my $actual = "";
-    while (<IN>) {
-        last if /#EOF/;
-        $actual .= $_;
+    eval {
+        local $SIG{ALRM} = sub { die "test timed out" }
+        alarm 60; # die if test takes more than a minute
+        eval { 
+            while (<IN>) {
+                last if /#EOF/;
+                $actual .= $_;
+            }
+        }
+        alarm 0; # cancel alarm
+    } 
+    alarm 0; # avoid race condition
+    my $alarm_error = $@;
+    die $alarm_error if $alarm_error && $alarm_error !~ /test timed out/; # reraise other errors
+    if ($alarm_error) {
+        printFailureMessageForTest($test, "Test timed out!");
+        killDumpTool();
+        next;
     }

DumpRenderTree support added by Brady in <http://trac.webkit.org/projects/webkit/changeset/30849>.

[Brady Eidson]

Indeed - DRT now has a Watchdog *thread* which is immune to deadlocks or "the timer thread going out to lunch"

It's turned on for DRTMac right now, and should be easy to turn on for other platforms DRT's as well.

[Adam Roben (:aroben)]

I'm working on a fix for this.

[Adam Roben (:aroben)]

Created attachment 20647 [details]
Cleanup 1

[Adam Roben (:aroben)]

Created attachment 20648 [details]
Cleanup 2

[Adam Roben (:aroben)]

Created attachment 20649 [details]
Cleanup 3

[Adam Roben (:aroben)]

Created attachment 20651 [details]
Cleanup 4

[Adam Roben (:aroben)]

Created attachment 20652 [details]
Cleanup 5

[Adam Roben (:aroben)]

Created attachment 20653 [details]
Fix v1

[Eric Seidel (no email)]

Comment on attachment 20653 [details]
Fix v1

Now we just need to lower the threshold in DRT until we have all tests passing in under 5 seconds. :)

[Adam Roben (:aroben)]

Fixed in r32029