Bug 176738

Summary:

Web Inspector: Remove unused parameter to UIString

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2017-09-11 14:26:51 PDT

Remove unused parameter to UIString UIString used to take variable arguments but we've moved to using String.format: WI.UIString("foo %s").format(...) So this parameter is no longer needed.

Attachments
[PATCH] Proposed Fix (1.31 KB, patch) 2017-09-11 14:27 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-09-11 14:27:39 PDT

Created attachment 320478 [details] [PATCH] Proposed Fix

Matt Baker

Comment 2 2017-09-11 14:42:48 PDT

Comment on attachment 320478 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2017-09-11 15:22:15 PDT

Comment on attachment 320478 [details] [PATCH] Proposed Fix Clearing flags on attachment: 320478 Committed r221884: <http://trac.webkit.org/changeset/221884>

WebKit Commit Bot

Comment 4 2017-09-11 15:22:16 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2017-09-27 12:34:40 PDT

<rdar://problem/34693518>

Note You need to log in before you can comment on or make changes to this bug.