Summary: | DOMFormData should be available in workers | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | Forms | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, ap, cdumez, commit-queue, dbates, dvpdiner2, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, mifenton, tkent, webkit-bug-importer, wenson_hsieh, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-09-10 14:01:54 PDT
As noted, the crux of the issue is that FormData class uses the Page to allow a hosting app to generate a file replacement for things like bundles. This was added in https://trac.webkit.org/changeset/32666/webkit (~9 years ago). My guess is that we can remove the delegation, and use the now available platform standard ways to detect bundles and generate the replacement. Indeed, it looks like we have most of the infrastructure in place to do this for Blobs already (File::shouldReplaceFile, File::computeNameAndContentTypeForReplacedFile, BlobDataFileReference::generateReplacementFile). There is some performance improvement to make potentially - I think that there are situations where we compress the same bundle twice, using the delegate first, and then in the Networking process using WebKit functionality again. (In reply to Sam Weinig from comment #2) > Indeed, it looks like we have most of the infrastructure in place to do this > for Blobs already (File::shouldReplaceFile, > File::computeNameAndContentTypeForReplacedFile, > BlobDataFileReference::generateReplacementFile). This has been removed now so we should be able to expose DOMFormData to workers Created attachment 383274 [details]
WIP
We probably need to handle the call of MIMETypeRegistry::getMIMETypeForExtension Created attachment 383275 [details]
Patch
Created attachment 383282 [details]
Patch
Created attachment 383289 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 383289 [details]: inspector/model/remote-object-weak-collection.html bug 202932 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 383289 [details] Patch Clearing flags on attachment: 383289 Committed r252349: <https://trac.webkit.org/changeset/252349> All reviewed patches have been landed. Closing bug. |