Bug 176674

Summary: DOMFormData should be available in workers
Product: WebKit Reporter: Sam Weinig <sam>
Component: FormsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, commit-queue, dbates, dvpdiner2, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, mifenton, tkent, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2017-09-10 14:01:54 PDT
DOMFormData is not currently available in workers due FormData (which DOMFormDatas are passed to for conversion to an HTTP body) currently depending on the Document/Page to do file replacement.
Attachments
WIP (37.39 KB, patch)
2019-11-11 09:20 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (38.50 KB, patch)
2019-11-11 09:29 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (182.26 KB, patch)
2019-11-11 10:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (184.44 KB, patch)
2019-11-11 12:59 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-09-10 17:39:21 PDT
As noted, the crux of the issue is that FormData class uses the Page to allow a hosting app to generate a file replacement for things like bundles. This was added in https://trac.webkit.org/changeset/32666/webkit (~9 years ago). My guess is that we can remove the delegation, and use the now available platform standard ways to detect bundles and generate the replacement.
Sam Weinig
Comment 2 2017-09-10 17:44:56 PDT
Indeed, it looks like we have most of the infrastructure in place to do this for Blobs already (File::shouldReplaceFile, File::computeNameAndContentTypeForReplacedFile, BlobDataFileReference::generateReplacementFile).
Alexey Proskuryakov
Comment 3 2017-09-11 12:20:40 PDT
There is some performance improvement to make potentially - I think that there are situations where we compress the same bundle twice, using the delegate first, and then in the Networking process using WebKit functionality again.
youenn fablet
Comment 4 2019-11-11 09:10:32 PST
(In reply to Sam Weinig from comment #2) > Indeed, it looks like we have most of the infrastructure in place to do this > for Blobs already (File::shouldReplaceFile, > File::computeNameAndContentTypeForReplacedFile, > BlobDataFileReference::generateReplacementFile). This has been removed now so we should be able to expose DOMFormData to workers
youenn fablet
Comment 5 2019-11-11 09:20:42 PST
Created attachment 383274 [details] WIP
youenn fablet
Comment 6 2019-11-11 09:24:39 PST
We probably need to handle the call of MIMETypeRegistry::getMIMETypeForExtension
youenn fablet
Comment 7 2019-11-11 09:29:58 PST
Created attachment 383275 [details] Patch
youenn fablet
Comment 8 2019-11-11 10:24:05 PST
Created attachment 383282 [details] Patch
youenn fablet
Comment 9 2019-11-11 12:59:54 PST
Created attachment 383289 [details] Patch
WebKit Commit Bot
Comment 10 2019-11-11 17:34:32 PST
The commit-queue encountered the following flaky tests while processing attachment 383289 [details]: inspector/model/remote-object-weak-collection.html bug 202932 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2019-11-11 17:35:29 PST
Comment on attachment 383289 [details] Patch Clearing flags on attachment: 383289 Committed r252349: <https://trac.webkit.org/changeset/252349>
WebKit Commit Bot
Comment 12 2019-11-11 17:35:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-11-11 17:36:18 PST
<rdar://problem/57100456>
Note You need to log in before you can comment on or make changes to this bug.