Bug 176627

Summary: Replace JS builtin implementation of the FetchResponse constructor with a C++ one
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2017-09-08 13:31:27 PDT
Replace JS builtin implementation of the FetchResponse constructor with a C++ one
Attachments
Patch (23.78 KB, patch)
2017-09-08 13:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (29.20 KB, patch)
2017-09-08 14:52 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (30.72 KB, patch)
2017-09-08 17:42 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-09-08 13:34:01 PDT
Created attachment 320292 [details] Patch
Sam Weinig
Comment 2 2017-09-08 14:52:16 PDT
Created attachment 320308 [details] Patch
Sam Weinig
Comment 3 2017-09-08 17:42:47 PDT
Created attachment 320319 [details] Patch
Alex Christensen
Comment 4 2017-09-08 17:56:41 PDT
Comment on attachment 320319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320319&action=review > Source/WebCore/Modules/fetch/FetchResponse.cpp:53 > + // 1. If initâs status member is not in the range 200 to 599, inclusive, then throw a RangeError. non-ascii apostrophes!
WebKit Commit Bot
Comment 5 2017-09-08 20:33:03 PDT
Comment on attachment 320319 [details] Patch Clearing flags on attachment: 320319 Committed r221806: <http://trac.webkit.org/changeset/221806>
WebKit Commit Bot
Comment 6 2017-09-08 20:33:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:35:23 PDT
<rdar://problem/34693544>
Note You need to log in before you can comment on or make changes to this bug.