Bug 176585

Summary: Use RenderLayerBacking::renderer() when possible
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176261    
Attachments:
Description Flags
Patch
none
Patch for landing
commit-queue: commit-queue-
Patch none

Frédéric Wang (:fredw)
Reported 2017-09-07 23:44:17 PDT
Small cleanup extracted from bug 176261. The private member renderer() is a shorthand for m_owningLayer.renderer() and can be used in various places of RenderLayerBacking.
Attachments
Patch (2.83 KB, patch)
2017-09-07 23:49 PDT, Frédéric Wang (:fredw)
no flags
Patch for landing (28.01 KB, patch)
2017-09-08 00:54 PDT, Frédéric Wang (:fredw)
commit-queue: commit-queue-
Patch (2.83 KB, patch)
2017-09-08 01:57 PDT, Frédéric Wang (:fredw)
no flags
Frédéric Wang (:fredw)
Comment 1 2017-09-07 23:49:59 PDT
WebKit Commit Bot
Comment 2 2017-09-08 00:34:30 PDT
Comment on attachment 320245 [details] Patch Rejecting attachment 320245 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320245, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 a71b4b74fa71caf5ee40505222e4ece8ea1c41c9 5f584218e40d75a9c39c52b76fd648459857f264 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/4484804
WebKit Commit Bot
Comment 3 2017-09-08 00:48:54 PDT
Comment on attachment 320245 [details] Patch Rejecting attachment 320245 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320245, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 a71b4b74fa71caf5ee40505222e4ece8ea1c41c9 5f584218e40d75a9c39c52b76fd648459857f264 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/4484869
Frédéric Wang (:fredw)
Comment 4 2017-09-08 00:54:35 PDT
Created attachment 320248 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-09-08 01:35:49 PDT
Comment on attachment 320248 [details] Patch for landing Rejecting attachment 320248 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320248, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 264 M Source :040000 040000 0855c73d1c70bced231228fcd6fbcf4c25fbc927 7faa3cb8917a0bdbd9d0d34942b8d5422ee72eb9 M Tools Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/4485186
Frédéric Wang (:fredw)
Comment 6 2017-09-08 01:57:22 PDT
WebKit Commit Bot
Comment 7 2017-09-09 02:35:36 PDT
Comment on attachment 320252 [details] Patch Clearing flags on attachment: 320252 Committed r221813: <http://trac.webkit.org/changeset/221813>
WebKit Commit Bot
Comment 8 2017-09-09 02:35:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-27 12:41:28 PDT
Note You need to log in before you can comment on or make changes to this bug.