Bug 176575 – Move LineEnding.{h,cpp} from WebCore/platform/text to wtf/text

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Move LineEnding.{h,cpp} from WebCore/platform/text to wtf/text

[Myles C. Maxfield]

Created attachment 320218 [details]
Patch

[Myles C. Maxfield]

Created attachment 320221 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 320221 [details]
Patch

Rejecting attachment 320221 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 320221, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ebCore/html/FormDataList.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file Source/WebCore/platform/text/LineEnding.cpp
rm 'Source/WebCore/platform/text/LineEnding.cpp'
patching file Source/WebCore/platform/text/LineEnding.h
rm 'Source/WebCore/platform/text/LineEnding.h'

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4528504

[Myles C. Maxfield]

Created attachment 320983 [details]
Patch for committing

[Darin Adler]

Comment on attachment 320221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320221&action=review

> Source/WTF/wtf/text/LineEnding.h:44
> +// Normalize all line-endings in the given string to the native line-endings and append the result to the given buffer.
> +// (Normalize to CRLF on Windows and normalize to LF on all other platforms.)
> +WTF_EXPORT void normalizeLineEndingsToNative(const CString& from, Vector<uint8_t>& result);

Function should have the word "append" in its name. Unless it always is used on an empty buffer, in which case it should be changed to return the Vector.

[Myles C. Maxfield]

Committed r222771: <http://trac.webkit.org/changeset/222771>

[Radar WebKit Bug Importer]

<rdar://problem/34785085>