Bug 176552

Summary: [Curl] Bug fix for synchronous transfer
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: WebCore Misc.Assignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, bfulgham, buildbot, commit-queue, don.olmstead, galpeter, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   
Attachments:
Description Flags
fix
none
fix2
none
fix3 none

Description Basuke Suzuki 2017-09-07 12:05:14 PDT 
ResourceHandleInternal::m_delegate is null when synchronous transfer invokes. It should be set to an instance of ResourceHandleCurlDelegate.
Also the callbacks to be called when transfer complete is wrong.
Comment 1 Basuke Suzuki 2017-09-07 16:12:50 PDT 
Created attachment 320201 [details]
fix
Comment 2 Build Bot 2017-09-07 16:15:10 PDT 
Attachment 320201 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Basuke Suzuki 2017-09-07 16:29:54 PDT 
Created attachment 320204 [details]
fix2
Comment 4 Build Bot 2017-09-07 16:32:43 PDT 
Attachment 320204 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Basuke Suzuki 2017-09-07 16:35:40 PDT 
Created attachment 320205 [details]
fix3
Comment 6 WebKit Commit Bot 2017-09-13 16:33:59 PDT 
Comment on attachment 320205 [details]
fix3

Clearing flags on attachment: 320205

Committed r221999: <http://trac.webkit.org/changeset/221999>
Comment 7 WebKit Commit Bot 2017-09-13 16:34:01 PDT 
All reviewed patches have been landed.  Closing bug.