Bug 176551

Summary:

Try to avoid creating the default WKWebsiteDataStore until its actually needed

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, mitz, rniwa, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	none
Patch	none

Brady Eidson

Reported 2017-09-07 11:41:26 PDT

Try to avoid creating the default WKWebsiteDataStore until its actually needed Clients can use WebKit without ever referencing the default data store, so we shouldn't create it in those cases.

Attachments
Patch (15.61 KB, patch) 2017-09-07 14:52 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.98 MB, application/zip) 2017-09-07 15:48 PDT, Build Bot	no flags	Details
Patch (15.80 KB, patch) 2017-09-07 15:52 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (18.91 KB, patch) 2017-09-09 10:13 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-09-07 11:41:36 PDT

<rdar://problem/33164453>

Brady Eidson

Comment 2 2017-09-07 14:52:56 PDT

Created attachment 320187 [details] Patch

Build Bot

Comment 3 2017-09-07 15:48:33 PDT

Comment on attachment 320187 [details] Patch Attachment 320187 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4479551 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html inspector/indexeddb/clearObjectStore.html inspector/indexeddb/requestDatabaseNames.html storage/indexeddb/modern/blob-svg-image.html storage/indexeddb/modern/blob-cursor.html inspector/indexeddb/requestData.html inspector/indexeddb/deleteDatabaseNamesWithSpace.html imported/w3c/web-platform-tests/IndexedDB/keygenerator-explicit.html

Build Bot

Comment 4 2017-09-07 15:48:35 PDT

Created attachment 320193 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Brady Eidson

Comment 5 2017-09-07 15:52:10 PDT

Created attachment 320194 [details] Patch

Brady Eidson

Comment 6 2017-09-09 10:13:22 PDT

Created attachment 320348 [details] Patch

Brady Eidson

Comment 7 2017-09-09 10:14:09 PDT

Had to make some "pending cookie" changes to fix a failing API test. One last EWS run.

Brady Eidson

Comment 8 2017-09-09 10:14:43 PDT

Oh... maybe the WK2 layotuttests are a real problem too. Exploring.

Brady Eidson

Comment 9 2017-09-09 10:29:49 PDT

(In reply to Brady Eidson from comment #8) > Oh... maybe the WK2 layotuttests are a real problem too. Exploring. Cant reproduce any locally, so I think changes I made to fix API tests could've had an effect.

WebKit Commit Bot

Comment 10 2017-09-10 09:36:56 PDT

Comment on attachment 320348 [details] Patch Clearing flags on attachment: 320348 Committed r221834: <http://trac.webkit.org/changeset/221834>

WebKit Commit Bot

Comment 11 2017-09-10 09:36:57 PDT

All reviewed patches have been landed. Closing bug.

mitz

Comment 12 2018-01-27 10:18:09 PST

Comment on attachment 320348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320348&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:41 > ++ (BOOL)_defaultDataStoreExists; This should have been annotated with WK_API_AVAILABLE

Note You need to log in before you can comment on or make changes to this bug.