Bug 176544

Summary:

[GStreamer] initializationDataEncountered() dispatch can outlive MediaPlayerPrivateGStreamerBase

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	calvaris: review+

Description Zan Dobersek 2017-09-07 10:47:13 PDT

[GStreamer] initializationDataEncountered() dispatch can outlive MediaPlayerPrivateGStreamerBase

Comment 1 Zan Dobersek 2017-09-07 10:51:11 PDT

Created attachment 320138 [details]
Patch

Comment 2 Xabier Rodríguez Calvar 2017-09-08 01:55:46 PDT

Comment on attachment 320138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320138&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:-367
> -        String sessionId(createCanonicalUUIDString());

If we're not using createCanonicalUUIDString() anymore, we can probably remove the UUID header.

Comment 3 Zan Dobersek 2017-09-08 03:57:38 PDT

Committed r221782: <http://trac.webkit.org/changeset/221782>

Comment 4 Zan Dobersek 2017-09-08 09:53:16 PDT

Reopening because the patch still hasn't officially landed due to svn.webkit.org issues.

Comment 5 Zan Dobersek 2017-09-09 05:40:42 PDT

This has in fact landed.

Comment 6 Radar WebKit Bug Importer 2017-09-27 13:02:35 PDT

<rdar://problem/34694530>