Bug 176472

Summary:

[Mac] Upstream QTKit-related WebKitSystemInterface functions

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, commit-queue, eric.carlson, jer.noble, joepeck, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

176614

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2017-09-06 11:37:38 PDT

[Mac] Upstream QTKit-related WebKitSystemInterface functions

Attachments
Patch (33.21 KB, patch) 2017-09-06 11:39 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (33.38 KB, patch) 2017-09-06 13:04 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (33.34 KB, patch) 2017-09-07 09:42 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (33.27 KB, patch) 2017-09-07 09:53 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (33.32 KB, patch) 2017-09-07 10:31 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (33.84 KB, patch) 2017-09-07 10:53 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (33.77 KB, patch) 2017-09-07 11:47 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (34.35 KB, patch) 2017-09-07 15:42 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (34.33 KB, patch) 2017-09-07 15:55 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (34.30 KB, patch) 2017-09-07 16:07 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (34.39 KB, patch) 2017-09-11 09:58 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-09-06 11:39:02 PDT Comment hidden (obsolete)

Created attachment 320044 [details] Patch

Build Bot

Comment 2 2017-09-06 11:40:53 PDT Comment hidden (obsolete)

Attachment 320044 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 3 2017-09-06 13:04:53 PDT Comment hidden (obsolete)

Created attachment 320053 [details] Patch

Build Bot

Comment 4 2017-09-06 13:07:18 PDT Comment hidden (obsolete)

Attachment 320053 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 5 2017-09-07 09:42:23 PDT Comment hidden (obsolete)

Created attachment 320120 [details] Patch

Build Bot

Comment 6 2017-09-07 09:44:19 PDT Comment hidden (obsolete)

Attachment 320120 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 7 2017-09-07 09:53:55 PDT Comment hidden (obsolete)

Created attachment 320121 [details] Patch

Build Bot

Comment 8 2017-09-07 09:55:16 PDT Comment hidden (obsolete)

Attachment 320121 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 9 2017-09-07 10:31:00 PDT Comment hidden (obsolete)

Created attachment 320129 [details] Patch

Build Bot

Comment 10 2017-09-07 10:33:42 PDT Comment hidden (obsolete)

Attachment 320129 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 11 2017-09-07 10:53:29 PDT Comment hidden (obsolete)

Created attachment 320139 [details] Patch

Build Bot

Comment 12 2017-09-07 10:55:55 PDT Comment hidden (obsolete)

Attachment 320139 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 13 2017-09-07 11:47:17 PDT Comment hidden (obsolete)

Created attachment 320148 [details] Patch

Build Bot

Comment 14 2017-09-07 11:49:59 PDT Comment hidden (obsolete)

Attachment 320148 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 15 2017-09-07 15:42:06 PDT Comment hidden (obsolete)

Created attachment 320192 [details] Patch

Build Bot

Comment 16 2017-09-07 15:43:35 PDT Comment hidden (obsolete)

Attachment 320192 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:356: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 17 2017-09-07 15:55:16 PDT Comment hidden (obsolete)

Created attachment 320195 [details] Patch

Build Bot

Comment 18 2017-09-07 15:58:03 PDT Comment hidden (obsolete)

Attachment 320195 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:352: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 19 2017-09-07 16:07:02 PDT Comment hidden (obsolete)

Created attachment 320199 [details] Patch

Build Bot

Comment 20 2017-09-07 16:08:47 PDT Comment hidden (obsolete)

Attachment 320199 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:352: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 21 2017-09-07 17:24:11 PDT Comment hidden (obsolete)

Comment on attachment 320199 [details] Patch Clearing flags on attachment: 320199 Committed r221773: <http://trac.webkit.org/changeset/221773>

WebKit Commit Bot

Comment 22 2017-09-07 17:24:13 PDT Comment hidden (obsolete)

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 23 2017-09-08 10:07:28 PDT Comment hidden (obsolete)

Re-opened since this is blocked by bug 176614

Andy Estes

Comment 24 2017-09-11 09:58:53 PDT

Created attachment 320436 [details] Patch