Summary: | [Mac] Upstream QTKit-related WebKitSystemInterface functions | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||||||||||||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, beidson, buildbot, commit-queue, eric.carlson, jer.noble, joepeck, thorton, webkit-bug-importer | ||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||
Bug Depends on: | 176614 | ||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||
Attachments: |
|
Description
Andy Estes
2017-09-06 11:37:38 PDT
Created attachment 320044 [details]
Patch
Attachment 320044 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320053 [details]
Patch
Attachment 320053 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320120 [details]
Patch
Attachment 320120 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320121 [details]
Patch
Attachment 320121 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320129 [details]
Patch
Attachment 320129 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320139 [details]
Patch
Attachment 320139 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320148 [details]
Patch
Attachment 320148 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320192 [details]
Patch
Attachment 320192 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:355: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:356: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320195 [details]
Patch
Attachment 320195 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:352: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320199 [details]
Patch
Attachment 320199 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:352: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:354: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 320199 [details] Patch Clearing flags on attachment: 320199 Committed r221773: <http://trac.webkit.org/changeset/221773> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 176614 Created attachment 320436 [details]
Patch
Comment on attachment 320436 [details] Patch Clearing flags on attachment: 320436 Committed r221863: <http://trac.webkit.org/changeset/221863> All reviewed patches have been landed. Closing bug. |