|
Description
Devin Rousso
2017-09-05 22:36:19 PDT
This is a great idea. Created attachment 320383 [details]
Patch
Comment on attachment 320383 [details] Patch Attachment 320383 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4502493 New failing tests: inspector/canvas/recording-2d.html inspector/canvas/recording-webgl-snapshots.html Created attachment 320386 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 320383 [details] Patch Attachment 320383 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4502501 New failing tests: inspector/canvas/recording-webgl-snapshots.html Created attachment 320388 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 320383 [details] Patch Attachment 320383 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4502502 New failing tests: inspector/canvas/recording-2d.html inspector/canvas/recording-webgl-snapshots.html Created attachment 320389 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 320403 [details]
Patch
Comment on attachment 320403 [details] Patch Attachment 320403 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4507030 New failing tests: inspector/canvas/recording-2d.html Created attachment 320405 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 320403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320403&action=review Awesome! r=me > LayoutTests/inspector/canvas/resources/recording-utilities.js:71 > + if (action.parameters[i] != action._payloadParameters[i] && Number.isInteger(action._payloadParameters[i])) Style: Can we use `!==` here? Comment on attachment 320403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320403&action=review > LayoutTests/inspector/canvas/resources/recording-utilities.js:81 > + for (let i = 0; i < action.trace.length; ++i) { You might want to use `k` instead of `i` again given you are already inside of an `i`. This would trigger "shadow" linter warnings, but it does behave fine right now, its just weird form. Comment on attachment 320403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320403&action=review >> LayoutTests/inspector/canvas/resources/recording-utilities.js:71 >> + if (action.parameters[i] != action._payloadParameters[i] && Number.isInteger(action._payloadParameters[i])) > > Style: Can we use `!==` here? The main reason for not using `!==` is that `1 !== true`, which is what happens when we swizzle boolean values. I could add another case for that, but I figured that this was slightly cleaner. >> LayoutTests/inspector/canvas/resources/recording-utilities.js:81 >> + for (let i = 0; i < action.trace.length; ++i) { > > You might want to use `k` instead of `i` again given you are already inside of an `i`. This would trigger "shadow" linter warnings, but it does behave fine right now, its just weird form. Crap. Weird that ESLint didn't show it :( Created attachment 320567 [details]
Patch
Comment on attachment 320567 [details] Patch Attachment 320567 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4527312 New failing tests: inspector/canvas/recording-2d.html Created attachment 320574 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 320730 [details]
Patch
Comment on attachment 320730 [details] Patch Attachment 320730 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4542658 New failing tests: inspector/canvas/recording-webgl.html Created attachment 320741 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 320743 [details]
Patch
Comment on attachment 320743 [details] Patch Attachment 320743 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4543612 New failing tests: inspector/canvas/recording-webgl.html Created attachment 320751 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 320757 [details]
Patch
Created attachment 320856 [details]
Patch
Comment on attachment 320856 [details] Patch Attachment 320856 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4552934 New failing tests: inspector/canvas/recording-webgl.html Created attachment 320861 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 320868 [details]
Patch
Comment on attachment 320868 [details]
Patch
r=me!
Comment on attachment 320868 [details] Patch Clearing flags on attachment: 320868 Committed r222182: <http://trac.webkit.org/changeset/222182> All reviewed patches have been landed. Closing bug. |