Bug 176427

Summary: Copy WebKit Permalink may generate wrong URL with SVN checkout
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Mac   
OS: macOS 10.12.4   
Attachments:
Description Flags
Patch darin: review+

Daniel Bates
Reported 2017-09-05 15:36:45 PDT
Using a SVN checkout of WebKit, Copy WebKit Permalink always generates a URL of the form https://trac.webkit.org/browser/trunk/X where X is the name of a file regardless the actual location of the file with name X. Steps to reproduce: 1. Open file Source/WebCore/rendering/style/RenderStyle.h in Xcode. 2. Place the text insertion point at the start of line 1. 3. Choose Xcode > Services > Copy WebKit Permalink Then the clipboard has a URL of the form: https://trac.webkit.org/browser/trunk/RenderStyle.h?rev=221617 But it should have a URL of the form: https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/style/RenderStyle.h?rev=221617
Attachments
Patch (6.17 KB, patch)
2017-09-05 15:45 PDT, Daniel Bates 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-09-05 15:45:05 PDT
Created attachment 319944 [details] Patch
Daniel Bates
Comment 2 2017-09-06 09:55:57 PDT
Committed r221679: <http://trac.webkit.org/changeset/221679>
Radar WebKit Bug Importer
Comment 3 2017-09-27 12:39:40 PDT
<rdar://problem/34693705>
Note You need to log in before you can comment on or make changes to this bug.