Bug 176414 – [WinCairo] Default XSLT support to OFF

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Don Olmstead]

The updated WinCairoRequirements is not building out libxslt so support should default to OFF.

There is still a check to see if XSLT is enabled in the CMake setup so its still possible to build with it on if someone wants that.

[Don Olmstead]

Created attachment 319934 [details]
Patch

[Alex Christensen]

Why don't we like XSLT any more?  I think we should leave it on.

[Don Olmstead]

(In reply to Alex Christensen from comment #2)
> Why don't we like XSLT any more?  I think we should leave it on.

We don't enable it on the PS4 and I didn't have any intentions of building it out for the updated WinCairoRequirements.

Awhile back Chromium had tried to deprecate it as well https://groups.google.com/a/chromium.org/d/msg/blink-dev/zIg2KC7PyH0/Ho1tm5mo7qAJ citing security bugs and usage of 0.02% of page views though it sounded like they walked back the decision.

To be clear you can still build with it if you explicitly enable it. I'm okay with building it out if this is a sticking point.

[Brent Fulgham]

I'm fine with this change, as long as it doesn't break the other WinCairo users (Alex?).

[Alex Christensen]

Comment on attachment 319934 [details]
Patch

I think I'm opposed to this change unless there's a good reason to remove XSLT support for lots of people.  Every port has it enabled, and it's supported in every browser.  It's not a hard-to-manage dependency.  There's not a lot of active development in the XSLT area.  If you want to make a port that doesn't have it, that's up to you.