Bug 176393 – Log stack-trace for run-webkit-tests when interrupted

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

We have a number of circumstances where run-webkit-tests gets stuck.  Debugging these issues is difficult since these issues can often only be reproduced on specific configurations and even then, are frequently flakey.  If run-webkit-tests printed a stack-trace when interrupted, these issues would be much easier to debug.

[Radar WebKit Bug Importer]

<rdar://problem/34262310>

[Jonathan Bedard]

Created attachment 319924 [details]
Patch

[Darin Adler]

Comment on attachment 319924 [details]
Patch

This is great for someone who is working on run-webkit-tests, or who is annoyed that it is stuck, but makes things worse if you are not working on run-webkit-test and are not annoyed, but just want to cancel it so you can correct a mistake or type another command.

I don’t think this should be turned on for everybody. I find these tools that dump stack traces whenever you interrupt them super-frustrating when just trying to use the tools to do my work.

[Darin Adler]

Comment on attachment 319924 [details]
Patch

Maybe have it just dump the stack trace into a file?

[Jonathan Bedard]

Created attachment 320024 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 320024 [details]
Patch

Clearing flags on attachment: 320024

Committed r222709: <http://trac.webkit.org/changeset/222709>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 178587

[Jonathan Bedard]

Created attachment 327187 [details]
Patch

[Jonathan Bedard]

Updating the patch so that when multiple processes print stack traces, they don't all go to the same file.

[Jonathan Bedard]

I think we should revive this change, it was just quite valuable in root-causing <https://bugs.webkit.org/show_bug.cgi?id=196694>.

[Lucas Forschler]

Comment on attachment 327187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327187&action=review

the two functions appear to be nearly identical to each other. is there any way to simplify the do reduce code duplication?

> Tools/Scripts/webkitpy/common/interupt_debugging.py:28
> +

nit: please alphabetize

> Tools/Scripts/webkitpy/common/interupt_debugging.py:63
> +def log_stack_trace_on_cntrl_c(output_file=None):

I usually see control abbreviated as CTRL

> Tools/Scripts/webkitpy/common/interupt_debugging.py:74
> +        file.write('cntrl C received\n')

CTRL+C received

[Jonathan Bedard]

Created attachment 366996 [details]
Patch

[Lucas Forschler]

Comment on attachment 366996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366996&action=review

lgtm.

> Tools/Scripts/webkitpy/common/interupt_debugging.py:28
> +

nit: alphabetize

[Jonathan Bedard]

Created attachment 366999 [details]
Patch

[Jonathan Bedard]

Created attachment 367000 [details]
Patch

[EWS Watchlist]

Attachment 367000 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:39:  No name 'interrupt_debugging' in module 'webkitpy.common'  [pylint/E0611] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Bedard]

Created attachment 367003 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367003 [details]
Patch

Clearing flags on attachment: 367003

Committed r244064: <https://trac.webkit.org/changeset/244064>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.