Bug 176388

Summary: Replace PseudoIdSet with OptionSet<PseudoId>
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: ASSIGNED ---    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Description Daniel Bates 2017-09-05 11:49:38 PDT
Replace PseudoIdSet with OptionSet<PseudoId>
Comment 1 Daniel Bates 2017-09-05 11:53:22 PDT
Created attachment 319919 [details]
Patch
Comment 2 Build Bot 2017-09-05 11:55:47 PDT Comment hidden (obsolete)
Comment 3 Daniel Bates 2017-09-05 15:12:43 PDT
Created attachment 319941 [details]
Patch
Comment 4 Build Bot 2017-09-05 15:15:46 PDT Comment hidden (obsolete)
Comment 5 Daniel Bates 2017-09-05 15:48:17 PDT
Created attachment 319945 [details]
Patch
Comment 6 Build Bot 2017-09-05 15:50:01 PDT
Attachment 319945 [details] did not pass style-queue:


ERROR: Source/WebCore/page/FrameView.cpp:624:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Daniel Bates 2017-09-05 15:56:14 PDT
(In reply to Build Bot from comment #6)
> Attachment 319945 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/page/FrameView.cpp:624:  Multi line control clauses
> should use braces.  [whitespace/braces] [4]
> Total errors found: 1 in 55 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

This is a false positive that is strangely due to line 626 being indented with eight space characters (why?). See bug #173859.
Comment 8 Daniel Bates 2017-09-05 15:59:11 PDT
Created attachment 319947 [details]
Patch
Comment 9 Daniel Bates 2017-09-05 16:07:55 PDT
Created attachment 319949 [details]
Patch
Comment 10 Daniel Bates 2017-09-05 16:14:55 PDT
Created attachment 319951 [details]
Patch
Comment 11 Daniel Bates 2017-09-05 16:47:07 PDT
Created attachment 319955 [details]
Patch
Comment 12 Daniel Bates 2017-09-05 16:52:49 PDT
Created attachment 319958 [details]
Patch
Comment 13 Daniel Bates 2017-09-05 17:02:19 PDT
Created attachment 319961 [details]
Patch
Comment 14 Daniel Bates 2017-09-06 09:53:30 PDT
Created attachment 320032 [details]
Patch
Comment 15 Daniel Bates 2017-09-06 10:09:44 PDT
Created attachment 320035 [details]
Patch
Comment 16 Daniel Bates 2017-09-06 10:45:21 PDT
Created attachment 320038 [details]
Patch
Comment 17 Daniel Bates 2017-09-06 10:57:14 PDT
Created attachment 320039 [details]
Patch
Comment 18 Daniel Bates 2017-09-06 11:07:23 PDT
Created attachment 320041 [details]
Patch
Comment 19 Build Bot 2017-09-06 12:12:48 PDT
Comment on attachment 320041 [details]
Patch

Attachment 320041 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4466112

New failing tests:
scrollbars/corner-resizer-window-inactive.html
scrollbars/scrollbar-parts-opacity.html
fast/scrolling/overlay-scrollbars-scroll-corner.html
scrollbars/scrollbar-drag-thumb-with-large-content.html
Comment 20 Build Bot 2017-09-06 12:12:50 PDT
Created attachment 320047 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 21 Build Bot 2017-09-06 12:30:36 PDT
Comment on attachment 320041 [details]
Patch

Attachment 320041 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4466306

New failing tests:
fast/scrolling/overlay-scrollbars-scroll-corner.html
scrollbars/scrollbar-drag-thumb-with-large-content.html
scrollbars/scrollbar-parts-opacity.html
Comment 22 Build Bot 2017-09-06 12:30:38 PDT
Created attachment 320048 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 23 Build Bot 2017-09-06 12:56:24 PDT
Comment on attachment 320041 [details]
Patch

Attachment 320041 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4466337

New failing tests:
fast/scrolling/overlay-scrollbars-scroll-corner.html
scrollbars/scrollbar-parts-opacity.html
Comment 24 Build Bot 2017-09-06 12:56:25 PDT
Created attachment 320050 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5