Bug 176388

Summary:

Replace PseudoIdSet with OptionSet<PseudoId>

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

ASSIGNED

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none

Daniel Bates

Reported 2017-09-05 11:49:38 PDT

Replace PseudoIdSet with OptionSet<PseudoId>

Attachments
Patch (102.19 KB, patch) 2017-09-05 11:53 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (103.48 KB, patch) 2017-09-05 15:12 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (103.48 KB, patch) 2017-09-05 15:48 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (103.61 KB, patch) 2017-09-05 15:59 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (104.17 KB, patch) 2017-09-05 16:07 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (104.54 KB, patch) 2017-09-05 16:14 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (106.72 KB, patch) 2017-09-05 16:47 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (107.16 KB, patch) 2017-09-05 16:52 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (109.75 KB, patch) 2017-09-05 17:02 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (112.46 KB, patch) 2017-09-06 09:53 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (112.67 KB, patch) 2017-09-06 10:09 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (113.55 KB, patch) 2017-09-06 10:45 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (113.55 KB, patch) 2017-09-06 10:57 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (114.17 KB, patch) 2017-09-06 11:07 PDT, Daniel Bates	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.64 MB, application/zip) 2017-09-06 12:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.59 MB, application/zip) 2017-09-06 12:30 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.38 MB, application/zip) 2017-09-06 12:56 PDT, Build Bot	no flags	Details
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-09-05 11:53:22 PDT

Created attachment 319919 [details] Patch

Build Bot

Comment 2 2017-09-05 11:55:47 PDT Comment hidden (obsolete)

Attachment 319919 [details] did not pass style-queue: ERROR: Source/WebCore/page/FrameView.cpp:624: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 3 2017-09-05 15:12:43 PDT

Created attachment 319941 [details] Patch

Build Bot

Comment 4 2017-09-05 15:15:46 PDT Comment hidden (obsolete)

Attachment 319941 [details] did not pass style-queue: ERROR: Source/WebCore/page/FrameView.cpp:624: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 5 2017-09-05 15:48:17 PDT

Created attachment 319945 [details] Patch

Build Bot

Comment 6 2017-09-05 15:50:01 PDT

Attachment 319945 [details] did not pass style-queue: ERROR: Source/WebCore/page/FrameView.cpp:624: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 7 2017-09-05 15:56:14 PDT

(In reply to Build Bot from comment #6) > Attachment 319945 [details] did not pass style-queue: > > > ERROR: Source/WebCore/page/FrameView.cpp:624: Multi line control clauses > should use braces. [whitespace/braces] [4] > Total errors found: 1 in 55 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This is a false positive that is strangely due to line 626 being indented with eight space characters (why?). See bug #173859.

Daniel Bates

Comment 8 2017-09-05 15:59:11 PDT

Created attachment 319947 [details] Patch

Daniel Bates

Comment 9 2017-09-05 16:07:55 PDT

Created attachment 319949 [details] Patch

Daniel Bates

Comment 10 2017-09-05 16:14:55 PDT

Created attachment 319951 [details] Patch

Daniel Bates

Comment 11 2017-09-05 16:47:07 PDT

Created attachment 319955 [details] Patch

Daniel Bates

Comment 12 2017-09-05 16:52:49 PDT

Created attachment 319958 [details] Patch

Daniel Bates

Comment 13 2017-09-05 17:02:19 PDT

Created attachment 319961 [details] Patch

Daniel Bates

Comment 14 2017-09-06 09:53:30 PDT

Created attachment 320032 [details] Patch

Daniel Bates

Comment 15 2017-09-06 10:09:44 PDT

Created attachment 320035 [details] Patch

Daniel Bates

Comment 16 2017-09-06 10:45:21 PDT

Created attachment 320038 [details] Patch

Daniel Bates

Comment 17 2017-09-06 10:57:14 PDT

Created attachment 320039 [details] Patch

Daniel Bates

Comment 18 2017-09-06 11:07:23 PDT

Created attachment 320041 [details] Patch

Build Bot

Comment 19 2017-09-06 12:12:48 PDT

Comment on attachment 320041 [details] Patch Attachment 320041 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4466112 New failing tests: scrollbars/corner-resizer-window-inactive.html scrollbars/scrollbar-parts-opacity.html fast/scrolling/overlay-scrollbars-scroll-corner.html scrollbars/scrollbar-drag-thumb-with-large-content.html

Build Bot

Comment 20 2017-09-06 12:12:50 PDT

Created attachment 320047 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 21 2017-09-06 12:30:36 PDT

Comment on attachment 320041 [details] Patch Attachment 320041 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4466306 New failing tests: fast/scrolling/overlay-scrollbars-scroll-corner.html scrollbars/scrollbar-drag-thumb-with-large-content.html scrollbars/scrollbar-parts-opacity.html

Build Bot

Comment 22 2017-09-06 12:30:38 PDT

Created attachment 320048 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 23 2017-09-06 12:56:24 PDT

Comment on attachment 320041 [details] Patch Attachment 320041 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4466337 New failing tests: fast/scrolling/overlay-scrollbars-scroll-corner.html scrollbars/scrollbar-parts-opacity.html

Build Bot

Comment 24 2017-09-06 12:56:25 PDT

Created attachment 320050 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Note You need to log in before you can comment on or make changes to this bug.