Bug 176276

Summary:

[Canvas] Split CanvasRenderingContext2D.idl into separate IDLs to match current HTML spec

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dino, joepeck, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Patch	dino: review+, commit-queue: commit-queue-

Description Sam Weinig 2017-09-02 08:55:53 PDT

[Canvas] Split CanvasRenderingContext2D.idl into seperate IDLs to match current HTML spec

Comment 1 Sam Weinig 2017-09-02 15:03:16 PDT Comment hidden (obsolete)

Created attachment 319742 [details]
Patch

Comment 2 Build Bot 2017-09-02 16:22:40 PDT Comment hidden (obsolete)

Comment on attachment 319742 [details]
Patch

Attachment 319742 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4437127

New failing tests:
fast/canvas/canvas-stroke-path.html
js/dom/global-constructors-attributes-dedicated-worker.html
inspector/canvas/recording-2d.html
fast/canvas/canvas-path-isPointInStroke.html
fast/canvas/winding-enumeration.html
fast/canvas/canvas-fill-path.html
fast/canvas/canvas-path-addPath.html
fast/canvas/canvas-clip-path.html
fast/canvas/canvas-path-isPointInPath.html

Comment 3 Build Bot 2017-09-02 16:22:41 PDT Comment hidden (obsolete)

Created attachment 319744 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 4 Build Bot 2017-09-02 16:27:58 PDT Comment hidden (obsolete)

Comment on attachment 319742 [details]
Patch

Attachment 319742 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4437138

New failing tests:
fast/canvas/canvas-stroke-path.html
js/dom/global-constructors-attributes-dedicated-worker.html
inspector/canvas/recording-2d.html
fast/canvas/canvas-path-isPointInStroke.html
fast/canvas/winding-enumeration.html
fast/canvas/canvas-fill-path.html
fast/canvas/canvas-path-addPath.html
fast/canvas/canvas-clip-path.html
fast/canvas/canvas-path-isPointInPath.html

Comment 5 Build Bot 2017-09-02 16:28:00 PDT Comment hidden (obsolete)

Created attachment 319745 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 6 Build Bot 2017-09-02 16:44:04 PDT Comment hidden (obsolete)

Comment on attachment 319742 [details]
Patch

Attachment 319742 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4437160

New failing tests:
fast/canvas/canvas-stroke-path.html
js/dom/global-constructors-attributes-dedicated-worker.html
inspector/canvas/recording-2d.html
fast/canvas/canvas-path-isPointInStroke.html
fast/canvas/winding-enumeration.html
fast/canvas/canvas-fill-path.html
fast/canvas/canvas-path-addPath.html
fast/canvas/canvas-clip-path.html
fast/canvas/canvas-path-isPointInPath.html

Comment 7 Build Bot 2017-09-02 16:44:06 PDT Comment hidden (obsolete)

Created attachment 319747 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 8 Build Bot 2017-09-02 16:52:03 PDT Comment hidden (obsolete)

Comment on attachment 319742 [details]
Patch

Attachment 319742 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4437168

New failing tests:
fast/canvas/canvas-stroke-path.html
js/dom/global-constructors-attributes-dedicated-worker.html
fast/canvas/canvas-path-isPointInStroke.html
fast/canvas/winding-enumeration.html
fast/canvas/canvas-fill-path.html
fast/canvas/canvas-path-addPath.html
fast/canvas/canvas-clip-path.html
fast/canvas/canvas-path-isPointInPath.html

Comment 9 Build Bot 2017-09-02 16:52:05 PDT Comment hidden (obsolete)

Created attachment 319748 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

Comment 10 Sam Weinig 2017-09-02 17:39:02 PDT Comment hidden (obsolete)

Created attachment 319749 [details]
Patch

Comment 11 Sam Weinig 2017-09-02 17:46:03 PDT

Created attachment 319750 [details]
Patch

Comment 12 WebKit Commit Bot 2017-09-03 14:19:33 PDT

Comment on attachment 319750 [details]
Patch

Rejecting attachment 319750 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 319750, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
anvas/recording-2d-expected.txt
patching file LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
patching file LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
patching file LayoutTests/platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4443715

Comment 13 Sam Weinig 2017-09-04 17:23:06 PDT

Committed r221598: <http://trac.webkit.org/changeset/221598>

Comment 14 Joseph Pecoraro 2017-09-05 11:59:50 PDT

Comment on attachment 319750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319750&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:589
> +    CanvasLineJoin join;
> +    if (stringValue == "round")
> +        join = CanvasLineJoin::Round;
> +    if (stringValue == "bevel")
> +        join = CanvasLineJoin::Bevel;
> +    if (stringValue == "miter")
> +        join = CanvasLineJoin::Miter;
> +    else
> +        return;

Something seems wrong here. Should this be an else/if chain? Otherwise `round` and `bevel` do nothing above.

Comment 15 Sam Weinig 2017-09-06 09:32:37 PDT

(In reply to Joseph Pecoraro from comment #14)
> Comment on attachment 319750 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319750&action=review
> 
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:589
> > +    CanvasLineJoin join;
> > +    if (stringValue == "round")
> > +        join = CanvasLineJoin::Round;
> > +    if (stringValue == "bevel")
> > +        join = CanvasLineJoin::Bevel;
> > +    if (stringValue == "miter")
> > +        join = CanvasLineJoin::Miter;
> > +    else
> > +        return;
> 
> Something seems wrong here. Should this be an else/if chain? Otherwise
> `round` and `bevel` do nothing above.

Good find Joe! Filed https://bugs.webkit.org/show_bug.cgi?id=176461 to track and fix this.

Comment 16 Radar WebKit Bug Importer 2017-09-27 12:53:32 PDT

<rdar://problem/34694219>