Summary: | Move UI Process part of the Remote Layer Tree code out of a Mac-specific directory | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, mitz, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 174097 | ||||||||||
Attachments: |
|
Description
Tim Horton
2017-09-02 01:09:00 PDT
Created attachment 319705 [details]
Patch
Oh, webkit-patch -g, you never quite do the right thing :( Created attachment 319711 [details]
Patch
Comment on attachment 319711 [details]
Patch
rs=me
Created attachment 319743 [details]
Patch for EWS
Attachment 319743 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:30: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:446: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.h:27: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:69: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:30: You should add a blank line after implementation file's own header. [build/include_order] [4]
ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebKit/PlatformMac.cmake:281: Alphabetical sorting problem. "UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm" should be before "UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp". [list/order] [5]
Total errors found: 10 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 319743 [details] Patch for EWS Clearing flags on attachment: 319743 Committed r221541: <http://trac.webkit.org/changeset/221541> All reviewed patches have been landed. Closing bug. |