| Summary: | Large virtual memory region allocation requires MMAP_NORESERVE in Linux | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2017-08-31 22:36:29 PDT
Created attachment 319579 [details]
Patch
Comment on attachment 319579 [details]
Patch
I have a slight preference for defining BMALLOC_MMAP_FLAGS at the top of the file like we have BMALLOC_VM_TAG. It's nice to factor platform logic out of the core logic of the function. I find #ifdef'd code hard to read.
Another option would be to define BMALLOC_NORESERVE at the top of the file, and make it something innocuous on Darwin like 0.
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 319579 [details] > Patch > > I have a slight preference for defining BMALLOC_MMAP_FLAGS at the top of the > file like we have BMALLOC_VM_TAG. It's nice to factor platform logic out of > the core logic of the function. I find #ifdef'd code hard to read. > > Another option would be to define BMALLOC_NORESERVE at the top of the file, > and make it something innocuous on Darwin like 0. BMALLOC_NORESERVE sounds very nice. I'll apply this change :) Committed r221548: <http://trac.webkit.org/changeset/221548> |