Bug 176211

Summary: Large virtual memory region allocation requires MMAP_NORESERVE in Linux
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Yusuke Suzuki
Reported 2017-08-31 22:36:29 PDT
Large virtual memory region allocation requires MMAP_NORESERVE in Linux
Attachments
Patch (2.38 KB, patch)
2017-08-31 22:59 PDT, Yusuke Suzuki 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-08-31 22:59:30 PDT
Created attachment 319579 [details] Patch
Geoffrey Garen
Comment 2 2017-09-01 11:16:58 PDT
Comment on attachment 319579 [details] Patch I have a slight preference for defining BMALLOC_MMAP_FLAGS at the top of the file like we have BMALLOC_VM_TAG. It's nice to factor platform logic out of the core logic of the function. I find #ifdef'd code hard to read. Another option would be to define BMALLOC_NORESERVE at the top of the file, and make it something innocuous on Darwin like 0.
Yusuke Suzuki
Comment 3 2017-09-03 03:22:59 PDT
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 319579 [details] > Patch > > I have a slight preference for defining BMALLOC_MMAP_FLAGS at the top of the > file like we have BMALLOC_VM_TAG. It's nice to factor platform logic out of > the core logic of the function. I find #ifdef'd code hard to read. > > Another option would be to define BMALLOC_NORESERVE at the top of the file, > and make it something innocuous on Darwin like 0. BMALLOC_NORESERVE sounds very nice. I'll apply this change :)
Yusuke Suzuki
Comment 4 2017-09-03 03:31:34 PDT
Committed r221548: <http://trac.webkit.org/changeset/221548>
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:52:26 PDT
<rdar://problem/34694184>
Note You need to log in before you can comment on or make changes to this bug.