Bug 176207

Summary: WSL should support loading from arrays
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: keith_miller, mmaxfield, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch saam: review+

Description Filip Pizlo 2017-08-31 19:28:53 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2017-08-31 19:36:43 PDT
Created attachment 319565 [details]
the patch
Comment 2 Saam Barati 2017-08-31 19:42:54 PDT
Comment on attachment 319565 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319565&action=review

> Tools/WebGPUShadingLanguageRI/Parse.js:182
> +            if (uintVersion + "u" != token.text)

I'd use !==
Comment 3 Filip Pizlo 2017-08-31 19:51:56 PDT
(In reply to Saam Barati from comment #2)
> Comment on attachment 319565 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319565&action=review
> 
> > Tools/WebGPUShadingLanguageRI/Parse.js:182
> > +            if (uintVersion + "u" != token.text)
> 
> I'd use !==

Fixed.
Comment 4 Filip Pizlo 2017-08-31 19:52:39 PDT
Landed in https://trac.webkit.org/changeset/221468/webkit
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:52:02 PDT
<rdar://problem/34694170>
Comment 6 Myles C. Maxfield 2018-10-13 19:58:46 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/202