Bug 176182

Summary:

[Fetch API] Add support for consuming a Request ReadableStream body

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2017-08-31 13:57:30 PDT

It should be possible to get data from it and consume it according Request getters.

Attachments
Patch (39.28 KB, patch) 2017-08-31 14:01 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (41.07 KB, patch) 2017-08-31 21:12 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (41.09 KB, patch) 2017-08-31 21:50 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (41.40 KB, patch) 2017-08-31 22:05 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (42.13 KB, patch) 2017-09-01 08:51 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (45.32 KB, patch) 2017-09-01 10:28 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (44.09 KB, patch) 2017-09-01 11:41 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (45.68 KB, patch) 2017-09-01 15:21 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-08-31 14:01:33 PDT

Created attachment 319519 [details] Patch

youenn fablet

Comment 2 2017-08-31 21:12:49 PDT

Created attachment 319572 [details] Patch

youenn fablet

Comment 3 2017-08-31 21:50:14 PDT

Created attachment 319574 [details] Patch

youenn fablet

Comment 4 2017-08-31 22:05:58 PDT

Created attachment 319575 [details] Patch

youenn fablet

Comment 5 2017-09-01 08:51:46 PDT

Created attachment 319597 [details] Patch

youenn fablet

Comment 6 2017-09-01 10:28:15 PDT

Created attachment 319611 [details] Patch

youenn fablet

Comment 7 2017-09-01 11:41:00 PDT

Created attachment 319625 [details] Patch

Alex Christensen

Comment 8 2017-09-01 14:45:51 PDT

Comment on attachment 319625 [details] Patch Let's add a test with an ArrayBuffer of size 0.

Alex Christensen

Comment 9 2017-09-01 14:50:00 PDT

We should also add a test for sending a request to a server that sends a 401 response then we need to send the request again.

youenn fablet

Comment 10 2017-09-01 15:21:56 PDT

Created attachment 319653 [details] Patch for landing

youenn fablet

Comment 11 2017-09-01 15:23:47 PDT

Thanks for the review. (In reply to Alex Christensen from comment #8) > Comment on attachment 319625 [details] > Patch > > Let's add a test with an ArrayBuffer of size 0. Done (In reply to Alex Christensen from comment #9) > We should also add a test for sending a request to a server that sends a 401 > response then we need to send the request again. Currently, uploading a stream with a request is still forbidden. A follow-up patch will allow this in which case we might want to add these kinds of test, especially when upload will be done in full streaming mode.

WebKit Commit Bot

Comment 12 2017-09-01 15:53:26 PDT

Comment on attachment 319653 [details] Patch for landing Clearing flags on attachment: 319653 Committed r221504: <http://trac.webkit.org/changeset/221504>

WebKit Commit Bot

Comment 13 2017-09-01 15:53:28 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 14 2017-09-27 12:55:58 PDT

<rdar://problem/34694295>

Note You need to log in before you can comment on or make changes to this bug.