Bug 176173

Summary: [CMake] Make USE_CF conditional within Windows
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, buildbot, commit-queue, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175336    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2017-08-31 11:37:45 PDT
Make USE_CF conditional rather than always on within the CMake and platform files.
Attachments
Patch (11.09 KB, patch)
2017-08-31 11:43 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (15.28 KB, patch)
2017-08-31 13:53 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (14.36 KB, patch)
2017-08-31 14:39 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-08-31 11:38:55 PDT
Doing this work before removing CFLite from WinCairo https://bugs.webkit.org/show_bug.cgi?id=175336
Don Olmstead
Comment 2 2017-08-31 11:43:18 PDT
Created attachment 319490 [details] Patch
Build Bot
Comment 3 2017-08-31 11:46:03 PDT
Attachment 319490 [details] did not pass style-queue: ERROR: Source/WebCore/PlatformWin.cmake:255: Alphabetical sorting problem. "platform/cf/win/CertificateCFWin.cpp" should be before "platform/text/cf/HyphenationCF.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWin.cmake:260: There should be exactly one empty line instead of 0 between "history/cf" and "loader/archive/cf". [list/emptyline] [5] ERROR: Source/WebCore/PlatformWin.cmake:261: There should be exactly one empty line instead of 0 between "loader/archive/cf" and "platform/cf". [list/emptyline] [5] ERROR: Source/WebCore/PlatformWin.cmake:262: There should be exactly one empty line instead of 0 between "platform/cf" and "platform/cf/win". [list/emptyline] [5] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 4 2017-08-31 13:53:42 PDT
Created attachment 319518 [details] Patch Fix style find other CF references
Build Bot
Comment 5 2017-08-31 13:55:06 PDT
Attachment 319518 [details] did not pass style-queue: ERROR: Source/WebCore/platform/text/win/LocaleWin.cpp:104: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/text/win/LocaleWin.cpp:105: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebCore/platform/text/win/LocaleWin.cpp:105: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 6 2017-08-31 14:39:03 PDT
Created attachment 319523 [details] Patch Removed some unrelated changes.
Don Olmstead
Comment 7 2017-08-31 15:14:02 PDT
Comment on attachment 319523 [details] Patch If win passes I think this is good to go.
Don Olmstead
Comment 8 2017-08-31 17:07:42 PDT
Comment on attachment 319523 [details] Patch Previous patch built in EWS and there isn't really any change so committing.
WebKit Commit Bot
Comment 9 2017-08-31 17:36:56 PDT
Comment on attachment 319523 [details] Patch Clearing flags on attachment: 319523 Committed r221463: <http://trac.webkit.org/changeset/221463>
WebKit Commit Bot
Comment 10 2017-08-31 17:36:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-09-27 12:43:48 PDT
<rdar://problem/34693842>
Note You need to log in before you can comment on or make changes to this bug.