Bug 176143

Summary: getFileMetadata() does not work as expected for symbolic links
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, esprehn+autocc, ggaren, gyuyoung.kim, kling, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175976    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-08-30 20:36:10 PDT
getFileMetadata() does not work as expected for symbolic links. It should provide metadata about the symlink, not its target. FileMetadata.type should properly be set to TypeSymbolicLink.
Attachments
Patch (19.73 KB, patch)
2017-08-30 22:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.47 KB, patch)
2017-08-30 22:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.64 KB, patch)
2017-08-31 09:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.43 KB, patch)
2017-08-31 09:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.51 KB, patch)
2017-08-31 11:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.78 KB, patch)
2017-08-31 13:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.62 KB, patch)
2017-08-31 13:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-08-30 22:12:19 PDT
Created attachment 319451 [details] Patch
Chris Dumez
Comment 2 2017-08-30 22:28:52 PDT
Created attachment 319453 [details] Patch
Chris Dumez
Comment 3 2017-08-31 09:08:22 PDT
Created attachment 319466 [details] Patch
Chris Dumez
Comment 4 2017-08-31 09:54:59 PDT
Created attachment 319468 [details] Patch
Chris Dumez
Comment 5 2017-08-31 11:05:54 PDT
Created attachment 319481 [details] Patch
Andreas Kling
Comment 6 2017-08-31 12:54:47 PDT
Comment on attachment 319481 [details] Patch r=me
Andreas Kling
Comment 7 2017-08-31 12:55:37 PDT
Comment on attachment 319481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319481&action=review > Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp:126 > + EXPECT_TRUE(createSymbolicLink(tempFilePath(), symlinkPath)); We should probably take care to remove this symlink at some point.
Chris Dumez
Comment 8 2017-08-31 13:02:01 PDT
Created attachment 319506 [details] Patch
Chris Dumez
Comment 9 2017-08-31 13:09:07 PDT
Created attachment 319507 [details] Patch
Chris Dumez
Comment 10 2017-08-31 13:53:42 PDT
Comment on attachment 319507 [details] Patch Clearing flags on attachment: 319507 Committed r221441: <http://trac.webkit.org/changeset/221441>
Chris Dumez
Comment 11 2017-08-31 13:53:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-09-27 13:02:00 PDT
<rdar://problem/34694512>
Note You need to log in before you can comment on or make changes to this bug.