Bug 176137

Summary:

Introduce CacheStorageEngineCache to handle cache records

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Rebasing	none
Fixing debug build	none
Rebasing	none

youenn fablet

Reported 2017-08-30 17:07:09 PDT

This will ease management of records to encapsulate it into its own class.

Attachments
Patch (20.12 KB, patch) 2017-08-30 17:14 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (26.42 KB, patch) 2017-08-30 17:17 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Rebasing (26.94 KB, patch) 2017-08-31 12:37 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Fixing debug build (27.12 KB, patch) 2017-08-31 13:36 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Rebasing (25.77 KB, patch) 2017-08-31 13:43 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-08-30 17:14:41 PDT

Created attachment 319425 [details] Patch

Build Bot

Comment 2 2017-08-30 17:16:50 PDT

Attachment 319425 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:111: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:254: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:95: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:101: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:105: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:128: More than one command on the same line [whitespace/newline] [4] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 3 2017-08-30 17:17:49 PDT

Created attachment 319426 [details] Patch

Build Bot

Comment 4 2017-08-30 17:19:58 PDT

Attachment 319426 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:84: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:111: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:254: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:95: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:101: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:105: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:128: More than one command on the same line [whitespace/newline] [4] Total errors found: 7 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 5 2017-08-31 11:16:16 PDT

Comment on attachment 319426 [details] Patch Rejecting attachment 319426 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 319426, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: WebKit/NetworkProcess/cache/CacheStorageEngine.h patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp patching file Source/WebKit/WebKit.xcodeproj/project.pbxproj Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4417668

youenn fablet

Comment 6 2017-08-31 12:37:38 PDT

Created attachment 319500 [details] Rebasing

Build Bot

Comment 7 2017-08-31 12:39:12 PDT

Attachment 319500 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:84: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:104: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:110: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:114: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:137: More than one command on the same line [whitespace/newline] [4] Total errors found: 5 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 8 2017-08-31 13:36:37 PDT

Created attachment 319512 [details] Fixing debug build

youenn fablet

Comment 9 2017-08-31 13:43:36 PDT

Created attachment 319515 [details] Rebasing

Build Bot

Comment 10 2017-08-31 13:46:08 PDT

Attachment 319515 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:84: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:104: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:110: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:114: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:137: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:140: More than one command on the same line [whitespace/newline] [4] Total errors found: 6 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 11 2017-08-31 14:55:20 PDT

Comment on attachment 319515 [details] Rebasing Clearing flags on attachment: 319515 Committed r221447: <http://trac.webkit.org/changeset/221447>

WebKit Commit Bot

Comment 12 2017-08-31 14:55:22 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 13 2017-09-27 12:51:29 PDT

<rdar://problem/34694153>

Note You need to log in before you can comment on or make changes to this bug.