| Summary: | Add "Identified" base class to replace a whole bunch of custom identifier generators | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | Web Template Framework | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, aestes, alecflett, benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, jsbell, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 319394 [details]
Patch
Comment on attachment 319394 [details] Patch Clearing flags on attachment: 319394 Committed r221399: <http://trac.webkit.org/changeset/221399> All reviewed patches have been landed. Closing bug. |
Add "Identified" base class to replace a whole bunch of custom identifier generators A common pattern in WebCore and WebKit is: uint64_t identifier() const { return m_identifier; } ... Along with a static function/generator to increment the next identifier for the next instance of the class. We repeat this code, a lot. And that's silly. Let's do it as a template base class instead.