Bug 176120

Summary: Add "Identified" base class to replace a whole bunch of custom identifier generators
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Web Template FrameworkAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, alecflett, benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2017-08-30 13:13:38 PDT
Add "Identified" base class to replace a whole bunch of custom identifier generators A common pattern in WebCore and WebKit is: uint64_t identifier() const { return m_identifier; } ... Along with a static function/generator to increment the next identifier for the next instance of the class. We repeat this code, a lot. And that's silly. Let's do it as a template base class instead.
Attachments
Patch (59.88 KB, patch)
2017-08-30 13:51 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-08-30 13:51:34 PDT
Created attachment 319394 [details] Patch
WebKit Commit Bot
Comment 2 2017-08-30 14:50:31 PDT
Comment on attachment 319394 [details] Patch Clearing flags on attachment: 319394 Committed r221399: <http://trac.webkit.org/changeset/221399>
WebKit Commit Bot
Comment 3 2017-08-30 14:50:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-08-30 14:51:50 PDT
<rdar://problem/34172937>
Note You need to log in before you can comment on or make changes to this bug.