| Summary: | [GTK] Avoid building fontconfig documentation in jhbuild | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||
| Component: | WebKitGTK | Assignee: | Tomas Popela <tpopela> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, clopez, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tomas Popela
2017-08-30 04:52:44 PDT
Created attachment 319357 [details]
Patch
Comment on attachment 319357 [details]
Patch
Informal review: r+
I wonder why we even had documentation enabled... A good idea could
be reviewing the whole JHBuild module set and disable other optional
features in packages which we don't need, and make a follo-up patch.
At any rate, I would already land this as-is now.
Comment on attachment 319357 [details] Patch Clearing flags on attachment: 319357 Committed r221370: <http://trac.webkit.org/changeset/221370> All reviewed patches have been landed. Closing bug. (In reply to Adrian Perez from comment #2) > I wonder why we even had documentation enabled... A good idea could > be reviewing the whole JHBuild module set and disable other optional > features in packages which we don't need, and make a follo-up patch. Good idea Adrian, I will look into it.. (In reply to Tomas Popela from comment #5) > (In reply to Adrian Perez from comment #2) > > I wonder why we even had documentation enabled... A good idea could > > be reviewing the whole JHBuild module set and disable other optional > > features in packages which we don't need, and make a follo-up patch. > > Good idea Adrian, I will look into it.. As a first pass I already disabled running “autogen.sh” for the modules which do not need it, see bug #176098 for the patch. I already did the same yesterday for the WPE JHBuild module set :-) |