Bug 176071
| Summary: | Layout Test inspector/debugger/breakpoints/resolved-dump-each-line.html is flaky. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | joepeck |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=161951 | ||
Matt Lewis
inspector/debugger/breakpoints/resolved-dump-each-line.html is a flaky timeout and failure. Currently the test is marked as a flaky timeout on macOS after this bug: https://bugs.webkit.org/show_bug.cgi?id=161951
History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreakpoints%2Fresolved-dump-each-line.html
Currently the test has begun to occasionally fail on Sierra WK2 Release according to the dashboard. There is not a clear regression point however the first failure was with this build:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3577
current builds:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r221307%20(3918)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3918
Diff:
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/breakpoints/resolved-dump-each-line-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/breakpoints/resolved-dump-each-line-actual.txt
@@ -4487,4 +4487,5 @@
INSERTING AT: 4:0
PRODUCES: Could not resolve breakpoint
-
+ERROR: TypeError: this._dispatcher is not an Object. (evaluating 'eventName in this._dispatcher')
+
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joseph Pecoraro
I have discovered what can cause this. I've made sure tests register a ScriptProfilerObserver and I've made the error message clear about which domain is missing having a dispatcher registered:
ERROR: No domain dispatcher registered for domain 'ScriptProfiler'
So this shouldn't happen anymore, and if it does we have a clear path to a solution. Closing this.