| Summary: | CallTracingCallback should ignore `readonly attribute` | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Bindings | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, mattbaker, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2017-08-29 15:05:08 PDT
Created attachment 319289 [details]
Patch
Comment on attachment 319289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319289&action=review r=me > Source/WebCore/ChangeLog:8 > + Updates existing bindings test with more cases. It seems like the thing to note is that the CallTracingCallback is not invoked for readonly attributes. Aren't the test cases just auto-generated? > Source/WebCore/ChangeLog:12 > + If the attribute is makred `readonly` do not add CallTracer logic. makred -> marked Comment on attachment 319289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319289&action=review >> Source/WebCore/ChangeLog:8 >> + Updates existing bindings test with more cases. > > It seems like the thing to note is that the CallTracingCallback is not invoked for readonly attributes. Aren't the test cases just auto-generated? The IDL file for the test case is not autogenerated, but the corresponding cpp/h files are. Created attachment 319293 [details]
Patch
Created attachment 319302 [details]
Patch
Comment on attachment 319302 [details] Patch Clearing flags on attachment: 319302 Committed r221336: <http://trac.webkit.org/changeset/221336> All reviewed patches have been landed. Closing bug. |