Bug 176070

Summary: CallTracingCallback should ignore `readonly attribute`
Product: WebKit Reporter: Devin Rousso <hi>
Component: BindingsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2017-08-29 15:05:08 PDT
A `readonly attribute` is unlikely to have any effect on the object being traced by CallTracer. Therefore, CallTracer probably doesn't need to instrument those getters, as it would most likely be unneeded information.
Attachments
Patch (9.40 KB, patch)
2017-08-29 15:10 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (9.44 KB, patch)
2017-08-29 15:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (117.03 KB, patch)
2017-08-29 16:26 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-08-29 15:10:32 PDT
Created attachment 319289 [details] Patch
Matt Baker
Comment 2 2017-08-29 15:19:28 PDT
Comment on attachment 319289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319289&action=review r=me > Source/WebCore/ChangeLog:8 > + Updates existing bindings test with more cases. It seems like the thing to note is that the CallTracingCallback is not invoked for readonly attributes. Aren't the test cases just auto-generated? > Source/WebCore/ChangeLog:12 > + If the attribute is makred `readonly` do not add CallTracer logic. makred -> marked
Devin Rousso
Comment 3 2017-08-29 15:38:35 PDT
Comment on attachment 319289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319289&action=review >> Source/WebCore/ChangeLog:8 >> + Updates existing bindings test with more cases. > > It seems like the thing to note is that the CallTracingCallback is not invoked for readonly attributes. Aren't the test cases just auto-generated? The IDL file for the test case is not autogenerated, but the corresponding cpp/h files are.
Devin Rousso
Comment 4 2017-08-29 15:39:22 PDT
Created attachment 319293 [details] Patch
Devin Rousso
Comment 5 2017-08-29 16:26:43 PDT
Created attachment 319302 [details] Patch
WebKit Commit Bot
Comment 6 2017-08-29 19:40:08 PDT
Comment on attachment 319302 [details] Patch Clearing flags on attachment: 319302 Committed r221336: <http://trac.webkit.org/changeset/221336>
WebKit Commit Bot
Comment 7 2017-08-29 19:40:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-08-29 19:41:26 PDT
<rdar://problem/34150808>
Note You need to log in before you can comment on or make changes to this bug.