Bug 176038

Summary:

Add initial support for dataTransferItem.webkitGetAsEntry()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, rniwa, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

175976

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-08-28 16:11:43 PDT

Add initial support for dataTransferItem.webkitGetAsEntry(): - https://wicg.github.io/entries-api/#html-data

Attachments
WIP Patch (64.81 KB, patch) 2017-08-28 16:15 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (66.89 KB, patch) 2017-08-28 20:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (77.10 KB, patch) 2017-08-28 21:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (76.92 KB, patch) 2017-08-29 09:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-08-28 16:12:27 PDT

<rdar://problem/34121095>

Chris Dumez

Comment 2 2017-08-28 16:15:59 PDT

Created attachment 319217 [details] WIP Patch

Chris Dumez

Comment 3 2017-08-28 20:22:43 PDT

Created attachment 319236 [details] WIP Patch

Chris Dumez

Comment 4 2017-08-28 21:06:14 PDT

Created attachment 319239 [details] Patch

Wenson Hsieh

Comment 5 2017-08-29 09:09:41 PDT

Comment on attachment 319239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319239&action=review > Source/WebCore/ChangeLog:100 > + Construct a DataTransferItem is the file is a directory now that we s/is the file/if the file/ > Source/WebCore/dom/DataTransferItem.cpp:111 > + if (!m_list || !m_list->dataTransfer().canReadData() || !m_file) Could we just use ::getAsFile() here and bail if it's null? (this would avoid duplicated checks for !m_list or !m_list->dataTransfer().canReadData()) > Source/WebCore/dom/DataTransferItemList.cpp:31 > +#include "FileSystem.h" Do we need this import? Looks like we've only added a call to File::isDirectory here.

Chris Dumez

Comment 6 2017-08-29 09:16:44 PDT

Created attachment 319254 [details] Patch

WebKit Commit Bot

Comment 7 2017-08-29 10:00:18 PDT

Comment on attachment 319254 [details] Patch Clearing flags on attachment: 319254 Committed r221302: <http://trac.webkit.org/changeset/221302>

WebKit Commit Bot

Comment 8 2017-08-29 10:00:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.