| Summary: | Logger should use makeString instead of String::format | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, buildbot, commit-queue, darin, jer.noble, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | Other | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=175988 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 30342 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Carlson
2017-08-28 14:01:14 PDT
Created attachment 319207 [details]
Proposed patch.
Attachment 319207 [details] did not pass style-queue:
ERROR: Source/WebCore/PAL/pal/Logger.h:39: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/Logger.h:137: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/PAL/pal/Logger.h:138: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319208 [details]
Proposed patch.
Created attachment 319212 [details]
Proposed patch.
Comment on attachment 319212 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=319212&action=review > Source/WebCore/PAL/pal/Logger.h:40 > + template<typename U = T> static typename std::enable_if<std::is_same<U, int>::value, String>::type toString(int argument) { return String::number(argument); } This could be slightly abbreviated if you used std::enable_if_t instead of std::enable_if<...>::type Created attachment 319227 [details]
Patch for landing.
The commit-queue encountered the following flaky tests while processing attachment 319227 [details]: http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (authors: abarth@webkit.org, jochen@chromium.org, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 319227 [details] Patch for landing. Clearing flags on attachment: 319227 Committed r221288: <http://trac.webkit.org/changeset/221288> Looks like this was resolved more than a year ago. |