Bug 176026

Summary: RenderMultiColumnFlowThread - Avoid render tree mutation during layout
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, rniwa, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-elcapitan
none
patch
none
patch none

Description Antti Koivisto 2017-08-28 10:37:35 PDT
computeColumnCountAndWidth -> createMultiColumnFlowThread
Comment 1 Antti Koivisto 2017-08-28 10:38:08 PDT
<rdar://problem/33402891>
Comment 2 Antti Koivisto 2017-08-28 10:40:14 PDT
Created attachment 319181 [details]
patch
Comment 3 Build Bot 2017-08-28 11:48:53 PDT
Comment on attachment 319181 [details]
patch

Attachment 319181 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4398306

New failing tests:
imported/blink/fast/pagination/first-letter-inherit-all-crash.html
Comment 4 Build Bot 2017-08-28 11:48:54 PDT
Created attachment 319187 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-08-28 11:54:44 PDT
Comment on attachment 319181 [details]
patch

Attachment 319181 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4398324

New failing tests:
imported/blink/fast/pagination/first-letter-inherit-all-crash.html
Comment 6 Build Bot 2017-08-28 11:54:46 PDT
Created attachment 319188 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-08-28 12:17:30 PDT
Comment on attachment 319181 [details]
patch

Attachment 319181 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4398341

New failing tests:
imported/blink/fast/pagination/first-letter-inherit-all-crash.html
Comment 8 Build Bot 2017-08-28 12:17:32 PDT
Created attachment 319190 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 9 Build Bot 2017-08-28 12:18:51 PDT
Comment on attachment 319181 [details]
patch

Attachment 319181 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4398342

New failing tests:
fast/css/content/quote-crash-when-floating.html
fast/css-generated-content/missing-quotes-with-dynamic-content.html
fast/inline/quotation-text-changes-dynamically.html
imported/blink/svg/text/layout-inline-children-assert.html
imported/blink/fast/pagination/first-letter-inherit-all-crash.html
fast/inline/out-of-flow-quotation-text-with-multicolumn.html
Comment 10 Build Bot 2017-08-28 12:18:53 PDT
Created attachment 319191 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Antti Koivisto 2017-08-28 19:17:22 PDT
Created attachment 319230 [details]
patch
Comment 12 Build Bot 2017-08-28 20:44:24 PDT
Comment on attachment 319230 [details]
patch

Attachment 319230 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4400847

New failing tests:
imported/blink/svg/text/layout-inline-children-assert.html
Comment 13 Build Bot 2017-08-28 20:44:25 PDT
Created attachment 319238 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Antti Koivisto 2017-08-29 20:47:57 PDT
Created attachment 319330 [details]
patch
Comment 15 Antti Koivisto 2017-08-30 09:30:26 PDT
Created attachment 319371 [details]
patch
Comment 16 WebKit Commit Bot 2017-08-30 10:28:13 PDT
Comment on attachment 319371 [details]
patch

Clearing flags on attachment: 319371

Committed r221379: <http://trac.webkit.org/changeset/221379>
Comment 17 WebKit Commit Bot 2017-08-30 10:28:15 PDT
All reviewed patches have been landed.  Closing bug.