Bug 176026

Summary:

RenderMultiColumnFlowThread - Avoid render tree mutation during layout

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, rniwa, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-elcapitan	none
patch	none
patch	none

Antti Koivisto

Reported 2017-08-28 10:37:35 PDT

computeColumnCountAndWidth -> createMultiColumnFlowThread

Attachments
patch (6.08 KB, patch) 2017-08-28 10:40 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.34 MB, application/zip) 2017-08-28 11:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.50 MB, application/zip) 2017-08-28 11:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.29 MB, application/zip) 2017-08-28 12:17 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.58 MB, application/zip) 2017-08-28 12:18 PDT, Build Bot	no flags	Details
patch (7.67 KB, patch) 2017-08-28 19:17 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (2.23 MB, application/zip) 2017-08-28 20:44 PDT, Build Bot	no flags	Details
patch (6.88 KB, patch) 2017-08-29 20:47 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (7.38 KB, patch) 2017-08-30 09:30 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-08-28 10:38:08 PDT

<rdar://problem/33402891>

Antti Koivisto

Comment 2 2017-08-28 10:40:14 PDT

Created attachment 319181 [details] patch

Build Bot

Comment 3 2017-08-28 11:48:53 PDT

Comment on attachment 319181 [details] patch Attachment 319181 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4398306 New failing tests: imported/blink/fast/pagination/first-letter-inherit-all-crash.html

Build Bot

Comment 4 2017-08-28 11:48:54 PDT

Created attachment 319187 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-08-28 11:54:44 PDT

Comment on attachment 319181 [details] patch Attachment 319181 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4398324 New failing tests: imported/blink/fast/pagination/first-letter-inherit-all-crash.html

Build Bot

Comment 6 2017-08-28 11:54:46 PDT

Created attachment 319188 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-08-28 12:17:30 PDT

Comment on attachment 319181 [details] patch Attachment 319181 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4398341 New failing tests: imported/blink/fast/pagination/first-letter-inherit-all-crash.html

Build Bot

Comment 8 2017-08-28 12:17:32 PDT

Created attachment 319190 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Build Bot

Comment 9 2017-08-28 12:18:51 PDT

Comment on attachment 319181 [details] patch Attachment 319181 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4398342 New failing tests: fast/css/content/quote-crash-when-floating.html fast/css-generated-content/missing-quotes-with-dynamic-content.html fast/inline/quotation-text-changes-dynamically.html imported/blink/svg/text/layout-inline-children-assert.html imported/blink/fast/pagination/first-letter-inherit-all-crash.html fast/inline/out-of-flow-quotation-text-with-multicolumn.html

Build Bot

Comment 10 2017-08-28 12:18:53 PDT

Created attachment 319191 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 11 2017-08-28 19:17:22 PDT

Created attachment 319230 [details] patch

Build Bot

Comment 12 2017-08-28 20:44:24 PDT

Comment on attachment 319230 [details] patch Attachment 319230 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4400847 New failing tests: imported/blink/svg/text/layout-inline-children-assert.html

Build Bot

Comment 13 2017-08-28 20:44:25 PDT

Created attachment 319238 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 14 2017-08-29 20:47:57 PDT

Created attachment 319330 [details] patch

Antti Koivisto

Comment 15 2017-08-30 09:30:26 PDT

Created attachment 319371 [details] patch

WebKit Commit Bot

Comment 16 2017-08-30 10:28:13 PDT

Comment on attachment 319371 [details] patch Clearing flags on attachment: 319371 Committed r221379: <http://trac.webkit.org/changeset/221379>

WebKit Commit Bot

Comment 17 2017-08-30 10:28:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.