Make fetch() use "same-origin" credentials by default

• Component: DOM
• Status: RESOLVED FIXED

[Anne van Kesteren]

See https://github.com/whatwg/fetch/pull/585 for rationale and proposed Fetch Standard change.

Please try to coordinate changing your implementation with others. It's unlikely to be disruptive, but still seems better if it all happens roughly at the same time.

[Anne van Kesteren]

Note: PR landed and test changes landed at https://github.com/w3c/web-platform-tests/pull/9911. It appears that Chrome and Firefox are planning to ship soon.

[youenn fablet]

Created attachment 344659 [details]
Patch

[EWS Watchlist]

Attachment 344659 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/NetworkLoadChecker.h:64:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 344659 [details]
Patch

Attachment 344659 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8490354

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-referrer.html
http/wpt/resource-timing/rt-cors.worker.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-referrer-worker.html
http/tests/inspector/network/resource-mime-type.html
http/wpt/resource-timing/rt-cors.html

[EWS Watchlist]

Created attachment 344664 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 344659 [details]
Patch

Attachment 344659 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8490376

New failing tests:
http/tests/inspector/network/resource-mime-type.html

[EWS Watchlist]

Created attachment 344665 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 344659 [details]
Patch

Attachment 344659 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8490510

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-referrer.html
http/wpt/resource-timing/rt-cors.worker.html
http/tests/inspector/network/resource-mime-type.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-referrer-worker.html
http/wpt/resource-timing/rt-cors.html

[EWS Watchlist]

Created attachment 344669 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 344711 [details]
Patch

[EWS Watchlist]

Attachment 344711 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/NetworkLoadChecker.h:64:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 344718 [details]
Patch

[EWS Watchlist]

Attachment 344718 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/NetworkLoadChecker.h:64:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 344718 [details]
Patch

Attachment 344718 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8497764

New failing tests:
accessibility/smart-invert-reference.html

[EWS Watchlist]

Created attachment 344721 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Comment on attachment 344718 [details]
Patch

Error is probably unrelated.

[WebKit Commit Bot]

Comment on attachment 344718 [details]
Patch

Clearing flags on attachment: 344718

Committed r233720: <https://trac.webkit.org/changeset/233720>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42053414>

[Devin Rhode]

I'm finding a fetch call in iOS 11 not sending any cookies. Based on the user agent, iOS 11 uses AppleWebkit 605.1.15.

What's the first version of webkit that has/had this change?

[Alexey Proskuryakov]

This fix went into iOS 12.