| Summary: | Fix incorrect enum in atBoundaryOfGranularity call | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, enrica, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Megan Gardner
2017-08-25 17:52:31 PDT
Created attachment 319123 [details]
Patch
Comment on attachment 319123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319123&action=review Nice find! r=me (though, this might still need a WK2R?) > Source/WebKit/ChangeLog:6 > + Enum that was being used was incorrect, as that case in not covered in called function. The ChangeLog description should go under the "Reviewed by" line. (also, it looks like you meant "is not covered" instead of "in not covered"). > Source/WebKit/ChangeLog:7 > + Resulted in a no-op, expected behavior will happen now. I think a sentence or two describing the "expected behavior" here would be helpful. What change in behavior did you observe after making this tweak? |