Bug 175996

Summary: Add Logger::logAlways
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
jer.noble: review+, commit-queue: commit-queue-
Patch for landing. none

Eric Carlson
Reported 2017-08-25 14:13:52 PDT
Add a method that logs regardless of a channel's log level.
Attachments
Proposed patch. (9.95 KB, patch)
2017-08-25 14:50 PDT, Eric Carlson 		jer.noble: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for landing. (9.90 KB, patch)
2017-08-25 19:24 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-08-25 14:50:50 PDT
Created attachment 319102 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2017-08-25 14:51:41 PDT
<rdar://problem/34089536>
WebKit Commit Bot
Comment 3 2017-08-25 16:04:16 PDT
Comment on attachment 319102 [details] Proposed patch. Rejecting attachment 319102 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: sts/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPILibrary.build/Objects-normal/x86_64/NewFirstVisuallyNonEmptyLayoutFails.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPILibrary.build/Objects-normal/x86_64/Logging.o Tests/WebCore/Logging.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/4383073
Eric Carlson
Comment 4 2017-08-25 19:24:23 PDT
Created attachment 319129 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2017-08-25 20:30:44 PDT
Comment on attachment 319129 [details] Patch for landing. Clearing flags on attachment: 319129 Committed r221221: <http://trac.webkit.org/changeset/221221>
WebKit Commit Bot
Comment 6 2017-08-25 20:30:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.