Summary: | [EME][GStreamer] Connect CDM to GStreamer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||
Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, buildbot, calvaris, cgarcia, commit-queue, darin, pnormand, webkit-bug-importer, zandobersek+ews, zan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 181289 | ||||||||
Attachments: |
|
Description
Xabier Rodríguez Calvar
2017-08-25 05:26:41 PDT
Created attachment 319074 [details]
Patch
Attachment 319074 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:30: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319081 [details]
Patch
Style correction
Comment on attachment 319081 [details] Patch Clearing flags on attachment: 319081 Committed r221224: <http://trac.webkit.org/changeset/221224> All reviewed patches have been landed. Closing bug. Comment on attachment 319081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319081&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053 > +#if ENABLE(ENCRYPTED_MEDIA) This ifdef is embedded in another one which is totally unrelated. (In reply to Philippe Normand from comment #7) > Comment on attachment 319081 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319081&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053 > > +#if ENABLE(ENCRYPTED_MEDIA) > > This ifdef is embedded in another one which is totally unrelated. You're absolutely right. I'll correct this build issue. (In reply to Xabier Rodríguez Calvar from comment #8) > (In reply to Philippe Normand from comment #7) > > Comment on attachment 319081 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=319081&action=review > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053 > > > +#if ENABLE(ENCRYPTED_MEDIA) > > > > This ifdef is embedded in another one which is totally unrelated. > > You're absolutely right. I'll correct this build issue. No need, I took care of it. See cloned bug (In reply to Philippe Normand from comment #9) > (In reply to Xabier Rodríguez Calvar from comment #8) > > (In reply to Philippe Normand from comment #7) > > > Comment on attachment 319081 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=319081&action=review > > > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053 > > > > +#if ENABLE(ENCRYPTED_MEDIA) > > > > > > This ifdef is embedded in another one which is totally unrelated. > > > > You're absolutely right. I'll correct this build issue. > > No need, I took care of it. See cloned bug Yes, I just saw it. It's a pity that bugzilla didn't show any comment about a cloned bug here. |