Bug 175983

Summary: [EME][GStreamer] Connect CDM to GStreamer
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, buildbot, calvaris, cgarcia, commit-queue, darin, pnormand, webkit-bug-importer, zandobersek+ews, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181289    
Attachments:
Description Flags
Patch
none
Patch none

Description Xabier Rodríguez Calvar 2017-08-25 05:26:41 PDT
[EME][GStreamer] Connect CDM to GStreamer
Comment 1 Xabier Rodríguez Calvar 2017-08-25 05:37:14 PDT
Created attachment 319074 [details]
Patch
Comment 2 Build Bot 2017-08-25 05:39:49 PDT
Attachment 319074 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:30:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xabier Rodríguez Calvar 2017-08-25 08:51:57 PDT
Created attachment 319081 [details]
Patch

Style correction
Comment 4 WebKit Commit Bot 2017-08-26 01:29:03 PDT
Comment on attachment 319081 [details]
Patch

Clearing flags on attachment: 319081

Committed r221224: <http://trac.webkit.org/changeset/221224>
Comment 5 WebKit Commit Bot 2017-08-26 01:29:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-26 01:30:20 PDT
<rdar://problem/34096610>
Comment 7 Philippe Normand 2018-01-04 07:17:32 PST
Comment on attachment 319081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319081&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053
> +#if ENABLE(ENCRYPTED_MEDIA)

This ifdef is embedded in another one which is totally unrelated.
Comment 8 Xabier Rodríguez Calvar 2018-01-09 00:51:29 PST
(In reply to Philippe Normand from comment #7)
> Comment on attachment 319081 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319081&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053
> > +#if ENABLE(ENCRYPTED_MEDIA)
> 
> This ifdef is embedded in another one which is totally unrelated.

You're absolutely right. I'll correct this build issue.
Comment 9 Philippe Normand 2018-01-09 00:54:40 PST
(In reply to Xabier Rodríguez Calvar from comment #8)
> (In reply to Philippe Normand from comment #7)
> > Comment on attachment 319081 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=319081&action=review
> > 
> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053
> > > +#if ENABLE(ENCRYPTED_MEDIA)
> > 
> > This ifdef is embedded in another one which is totally unrelated.
> 
> You're absolutely right. I'll correct this build issue.

No need, I took care of it. See cloned bug
Comment 10 Xabier Rodríguez Calvar 2018-01-09 01:27:31 PST
(In reply to Philippe Normand from comment #9)
> (In reply to Xabier Rodríguez Calvar from comment #8)
> > (In reply to Philippe Normand from comment #7)
> > > Comment on attachment 319081 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=319081&action=review
> > > 
> > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1053
> > > > +#if ENABLE(ENCRYPTED_MEDIA)
> > > 
> > > This ifdef is embedded in another one which is totally unrelated.
> > 
> > You're absolutely right. I'll correct this build issue.
> 
> No need, I took care of it. See cloned bug

Yes, I just saw it. It's a pity that bugzilla didn't show any comment about a cloned bug here.