Summary: | Weird getComputedStyle behavior for pseudo-elements on layout-dependent properties. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emilio Cobos Álvarez (:emilio) <emilio> | ||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ecobos, koivisto, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=37835 https://bugs.chromium.org/p/chromium/issues/detail?id=758596 |
||||||||||
Attachments: |
|
Created attachment 318997 [details]
Patch
Antti, could you review this? Also, I don't know what the deal is with wpt, do the tests get auto-exported? Or do I need to submit a PR manually? Thanks! Comment on attachment 318997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318997&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2386 > +RenderObject* ComputedStyleExtractor::styledRenderObject() const styledRenderer() would be a better name. Also this can return RenderElement* Per https://www.mail-archive.com/webkit-dev@lists.webkit.org/msg27587.html I submitted tests to https://github.com/w3c/web-platform-tests/pull/7020. Will upload a patch with the review comments addressed when that is merged. Thanks for the review Antti! Created attachment 319644 [details]
Patch
Comment on attachment 319644 [details] Patch Clearing flags on attachment: 319644 Committed r221501: <http://trac.webkit.org/changeset/221501> All reviewed patches have been landed. Closing bug. |
Created attachment 318985 [details] testcase See the test-case. The width of the actual element is reported. I'd expect "auto" to be alerted, given it's the default value for the "width" property.