Bug 175935

Summary:

[iOS WK2] WebPage::sendPartialEditorStateAndSchedulePostLayoutUpdate is sending full EditorStates on selection change

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

thorton, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
EWS trial run	buildbot: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch	none

Wenson Hsieh

Reported 2017-08-24 08:04:12 PDT

Followup to <rdar://problem/33799806>

Attachments
Patch (2.08 KB, patch) 2017-08-24 08:14 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
EWS trial run (3.30 KB, patch) 2017-08-24 08:38 PDT, Wenson Hsieh	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.17 MB, application/zip) 2017-08-24 10:18 PDT, Build Bot	no flags	Details
Patch (8.45 KB, patch) 2017-08-24 21:55 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (8.45 KB, patch) 2017-08-25 00:01 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-08-24 08:14:58 PDT

Created attachment 318986 [details] Patch

Wenson Hsieh

Comment 2 2017-08-24 08:38:51 PDT

Created attachment 318989 [details] EWS trial run

Build Bot

Comment 3 2017-08-24 10:17:59 PDT

Comment on attachment 318989 [details] EWS trial run Attachment 318989 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4375625 New failing tests: editing/selection/character-granularity-rect.html fast/events/focusing-element-with-tabindex-by-tap-or-click.html

Build Bot

Comment 4 2017-08-24 10:18:00 PDT

Created attachment 318995 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Wenson Hsieh

Comment 5 2017-08-24 21:55:16 PDT

Created attachment 319062 [details] Patch

Wenson Hsieh

Comment 6 2017-08-25 00:01:29 PDT

Created attachment 319067 [details] Patch

Wenson Hsieh

Comment 7 2017-08-25 11:20:43 PDT

Comment on attachment 319067 [details] Patch Bizarrely, this is a ~1% regression on Speedometer on iOS. Holding off until I figure out why...

Wenson Hsieh

Comment 8 2019-05-03 10:07:06 PDT

This is now fixed.

Note You need to log in before you can comment on or make changes to this bug.